github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2026-07-17 11:28:58 +00:00
Code Issues Projects Releases Wiki Activity

Use DeepCopy in GetLimits to avoid returning direct references to resource quantities, ensuring that changes to the returned ResourceList do not affect the original spec

Browse Source
This commit is contained in:
ndixita
2026-03-19 06:32:14 +00:00
parent 880a6dda4c
commit 991f2d727a
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
pkg/kubelet/util/util.go
View File

@@ -84,7 +84,7 @@ func GetLimits(res *ResourceOpts) v1.ResourceList {
if containerResources == nil || containerResources.Limits == nil {
return v1.ResourceList{}
}
return containerResources.Limits
return containerResources.Limits.DeepCopy()
}
containerLimits := limitsOrEmpty(res.ContainerResources)
@@ -99,13 +99,13 @@ func GetLimits(res *ResourceOpts) v1.ResourceList {
// When container-level CPU limit is not set, the pod-level
// limit CPU is applied at container-level
if containerLimits.Cpu().IsZero() && !podLevelLimits.Cpu().IsZero() {
containerLimits[v1.ResourceCPU] = podLevelLimits[v1.ResourceCPU]
containerLimits[v1.ResourceCPU] = podLevelLimits[v1.ResourceCPU].DeepCopy()
}
// When container-level Memory limit is not set, the pod-level
// limit Memory is applied at container-level
if containerLimits.Memory().IsZero() && !podLevelLimits.Memory().IsZero() {
containerLimits[v1.ResourceMemory] = podLevelLimits[v1.ResourceMemory]
containerLimits[v1.ResourceMemory] = podLevelLimits[v1.ResourceMemory].DeepCopy()
}
return containerLimits
}