github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-09 03:57:41 +00:00
Code Issues Projects Releases Wiki Activity

Fix unknown field error in deployment lifecycle e2e

Browse Source 
The terminationGracePeriodSeconds field was capitalized wrongly, leading
to unknown field warning when running deployment lifecycle e2e:

STEP: patching the Deployment @ 01/06/23 10:59:25.969
W0106 10:59:25.978292  433473 warnings.go:70] unknown field "spec.template.spec.TerminationGracePeriodSeconds"

The issue was undiscovered because the patched value didn't change, so
the test would succeed anyway.

Signed-off-by: Quan Tian <qtian@vmware.com>
This commit is contained in:
Quan Tian 2023-01-06 19:02:24 +08:00
parent e048acbc03
commit 9b9f22f06b
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
test/e2e/apps/deployment.go
View File

@ -184,6 +184,7 @@ var _ = SIGDescribe("Deployment", func() {
*/
framework.ConformanceIt("should run the lifecycle of a Deployment", func(ctx context.Context) {
one := int64(1)
two := int64(2)
deploymentResource := schema.GroupVersionResource{Group: "apps", Version: "v1", Resource: "deployments"}
testNamespaceName := f.Namespace.Name
testDeploymentName := "test-deployment"
@ -259,7 +260,7 @@ var _ = SIGDescribe("Deployment", func() {
"replicas": testDeploymentMinimumReplicas,
"template": map[string]interface{}{
"spec": map[string]interface{}{
"TerminationGracePeriodSeconds": &one,
"terminationGracePeriodSeconds": &two,
"containers": [1]map[string]interface{}{{
"name": testDeploymentName,
"image": testDeploymentPatchImage,
@ -301,7 +302,8 @@ var _ = SIGDescribe("Deployment", func() {
deployment.Status.ReadyReplicas == testDeploymentMinimumReplicas &&
deployment.Status.UpdatedReplicas == testDeploymentMinimumReplicas &&
deployment.Status.UnavailableReplicas == 0 &&
deployment.Spec.Template.Spec.Containers[0].Image == testDeploymentPatchImage
deployment.Spec.Template.Spec.Containers[0].Image == testDeploymentPatchImage &&
*deployment.Spec.Template.Spec.TerminationGracePeriodSeconds == two
if !found {
framework.Logf("observed Deployment %v in namespace %v with ReadyReplicas %v", deployment.ObjectMeta.Name, deployment.ObjectMeta.Namespace, deployment.Status.ReadyReplicas)
}