github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-31 23:37:01 +00:00
Code Issues Projects Releases Wiki Activity

apiserver/filters test: fix data race and do not leak goroutines

Browse Source 
Signed-off-by: Adhityaa Chandrasekar <adtac@google.com>
This commit is contained in:
Adhityaa Chandrasekar 2020-11-04 18:58:06 +00:00
parent 396b90f06c
commit a2eb6d67ee
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
staging/src/k8s.io/apiserver/pkg/server/filters/priority-and-fairness_test.go
View File

@ -294,15 +294,17 @@ func TestApfExecuteMultipleRequests(t *testing.T) {
defer cancel()
StartPriorityAndFairnessWatermarkMaintenance(ctx.Done())
var wg sync.WaitGroup
wg.Add(concurrentRequests)
for i := 0; i < concurrentRequests; i++ {
var err error
go func() {
err = expectHTTPGet(fmt.Sprintf("%s/api/v1/namespaces/default", server.URL), http.StatusOK)
defer wg.Done()
if err := expectHTTPGet(fmt.Sprintf("%s/api/v1/namespaces/default", server.URL), http.StatusOK); err != nil {
t.Error(err)
}
}()
if err != nil {
t.Error(err)
}
}
wg.Wait()
checkForExpectedMetricsWithRetry(t, []string{
"apiserver_current_inflight_requests",