Merge pull request #86501 from yutedz/crd-reuse-converter

Reuse converter in crdHandler#getOrCreateServingInfoFor
This commit is contained in:
Kubernetes Prow Robot 2020-01-07 03:20:17 -08:00 committed by GitHub
commit a302f64cd3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -654,11 +654,11 @@ func (r *crdHandler) getOrCreateServingInfoFor(uid types.UID, name string) (*crd
openAPIModels = nil
}
safeConverter, unsafeConverter, err := r.converterFactory.NewConverter(crd)
if err != nil {
return nil, err
}
for _, v := range crd.Spec.Versions {
safeConverter, unsafeConverter, err := r.converterFactory.NewConverter(crd)
if err != nil {
return nil, err
}
// In addition to Unstructured objects (Custom Resources), we also may sometimes need to
// decode unversioned Options objects, so we delegate to parameterScheme for such types.
parameterScheme := runtime.NewScheme()