github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-23 11:50:44 +00:00
Code Issues Projects Releases Wiki Activity

apiserver: fix Cacher.Stop() race

Browse Source
This commit is contained in:
Dr. Stefan Schimanski 2017-11-06 15:37:07 +01:00
parent 210626577b
commit a30c0f477d
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
staging/src/k8s.io/apiserver/pkg/storage/cacher.go
View File

@ -649,13 +649,15 @@ func (c *Cacher) isStopped() bool {
}
func (c *Cacher) Stop() {
// TODO : Do not check for isStopped (and return) when PR
// https://github.com/kubernetes/kubernetes/pull/50690
// merges as that shuts down storage properly
// avoid stopping twice (note: cachers are shared with subresources)
if c.isStopped() {
return
}
c.stopLock.Lock()
if c.stopped {
// avoid that it was locked meanwhile as isStopped only read-locks
return
}
c.stopped = true
c.stopLock.Unlock()
close(c.stopCh)