github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-09-13 21:25:09 +00:00
Code Issues Projects Releases Wiki Activity

test: Improve error comparison in resource validation tests

Browse Source 
Replace manual error logging with cmp.Diff for more precise error comparisons, using cmpopts to ignore Origin field and support UniqueString comparison.
This commit is contained in:
yongruilin
2025-02-21 22:30:23 +00:00
parent 02f7dc55d1
commit a488509197
1 changed files with 5 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
pkg/apis/resource/validation/validation_common_test.go
View File

@@ -19,9 +19,12 @@ package validation
import (
"testing"
"github.com/google/go-cmp/cmp"
"github.com/google/go-cmp/cmp/cmpopts"
"github.com/stretchr/testify/assert"
"k8s.io/apimachinery/pkg/util/validation/field"
"k8s.io/dynamic-resource-allocation/api"
)
// assertFailures compares the expected against the actual errors.
@@ -31,22 +34,13 @@ import (
// is informative.
func assertFailures(tb testing.TB, want, got field.ErrorList) bool {
tb.Helper()
if !assert.Equal(tb, want, got) {
logFailures(tb, "Wanted failures", want)
logFailures(tb, "Got failures", got)
if diff := cmp.Diff(want, got, cmpopts.IgnoreFields(field.Error{}, "Origin"), cmp.AllowUnexported(api.UniqueString{})); diff != "" {
tb.Errorf("unexpected field errors (-want, +got):\n%s", diff)
return false
}
return true
}
func logFailures(tb testing.TB, header string, errs field.ErrorList) {
tb.Helper()
tb.Logf("%s:\n", header)
for _, err := range errs {
tb.Logf("- %s\n", err)
}
}
func TestTruncateIfTooLong(t *testing.T) {
for name, tc := range map[string]struct {
str string