github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-30 15:05:27 +00:00
Code Issues Projects Releases Wiki Activity

cap nunmber of tries on e2e nodePort stop service test

Browse Source 
The tests were asserting that after a NodePort Service was removed,
no new traffic was still reaching the endpoints.
However, the number of tries was so large that another test running
in parallel could create a working Service on that NodePort, making
the test fails.

Use only 10 tries to confirm that the Service stopped working.
This commit is contained in:
Antonio Ojea 2021-12-13 10:33:35 +01:00
parent 0cae5f5006
commit a4bbf92577
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
test/e2e/network/networking.go
View File

@ -369,9 +369,12 @@ var _ = common.SIGDescribe("Networking", func() {
config.DeleteNodePortService()
ginkgo.By(fmt.Sprintf("dialing(http) %v (node) --> %v:%v (nodeIP) and getting ZERO host endpoints", config.NodeIP, config.NodeIP, config.NodeHTTPPort))
err = config.DialFromNode("http", config.NodeIP, config.NodeHTTPPort, config.MaxTries, config.MaxTries, sets.NewString())
// #106770 MaxTries can be very large on large clusters, with the risk that a new NodePort is created by another test and start to answer traffic.
// Since we only want to assert that traffic is not being forwarded anymore and the retry timeout is 2 seconds, consider the test is correct
// if the service doesn't answer after 10 tries.
err = config.DialFromNode("http", config.NodeIP, config.NodeHTTPPort, 10, 10, sets.NewString())
if err != nil {
framework.Failf("Error dialing http from node: %v", err)
framework.Failf("Failure validating that node port service STOPPED removed properly: %v", err)
}
})
@ -398,7 +401,10 @@ var _ = common.SIGDescribe("Networking", func() {
config.DeleteNodePortService()
ginkgo.By(fmt.Sprintf("dialing(udp) %v (node) --> %v:%v (nodeIP) and getting ZERO host endpoints", config.NodeIP, config.NodeIP, config.NodeUDPPort))
err = config.DialFromNode("udp", config.NodeIP, config.NodeUDPPort, config.MaxTries, config.MaxTries, sets.NewString())
// #106770 MaxTries can be very large on large clusters, with the risk that a new NodePort is created by another test and start to answer traffic.
// Since we only want to assert that traffic is not being forwarded anymore and the retry timeout is 2 seconds, consider the test is correct
// if the service doesn't answer after 10 tries.
err = config.DialFromNode("udp", config.NodeIP, config.NodeUDPPort, 10, 10, sets.NewString())
if err != nil {
framework.Failf("Failure validating that node port service STOPPED removed properly: %v", err)
}