github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-19 18:02:01 +00:00
Code Issues Projects Releases Wiki Activity

Fix linter and bazel errors

Browse Source
This commit is contained in:
Jesus Herrera 2020-05-21 23:06:56 -04:00
parent 6b8e2cc24e
commit a5800ab4cb
3 changed files with 12 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
plugin/pkg/admission/runtimeclass/BUILD
View File

@ -31,6 +31,8 @@ go_test(
embed = [":go_default_library"],
deps = [
"//pkg/apis/core:go_default_library",
"//pkg/controller:go_default_library",
"//pkg/features:go_default_library",
"//staging/src/k8s.io/api/core/v1:go_default_library",
"//staging/src/k8s.io/api/node/v1beta1:go_default_library",
"//staging/src/k8s.io/apimachinery/pkg/api/resource:go_default_library",
@ -38,6 +40,10 @@ go_test(
"//staging/src/k8s.io/apimachinery/pkg/runtime:go_default_library",
"//staging/src/k8s.io/apiserver/pkg/admission:go_default_library",
"//staging/src/k8s.io/apiserver/pkg/authentication/user:go_default_library",
"//staging/src/k8s.io/client-go/informers:go_default_library",
"//staging/src/k8s.io/client-go/kubernetes:go_default_library",
"//staging/src/k8s.io/client-go/kubernetes/fake:go_default_library",
"//staging/src/k8s.io/component-base/featuregate:go_default_library",
"//vendor/github.com/stretchr/testify/assert:go_default_library",
],
)

1
plugin/pkg/admission/runtimeclass/admission.go
View File

@ -74,6 +74,7 @@ var _ admission.ValidationInterface = &RuntimeClass{}
var _ genericadmissioninitailizer.WantsExternalKubeInformerFactory = &RuntimeClass{}
var _ genericadmissioninitailizer.WantsExternalKubeClientSet = &RuntimeClass{}
// SetExternalKubeClientSet sets the client for the plugin
func (r *RuntimeClass) SetExternalKubeClientSet(client kubernetes.Interface) {
r.runtimeClassClient = client.NodeV1beta1().RuntimeClasses()
}

12
plugin/pkg/admission/runtimeclass/admission_test.go
View File

@ -1,4 +1,3 @@
/*
Copyright 2019 The Kubernetes Authors.
@ -30,12 +29,12 @@ import (
"k8s.io/apimachinery/pkg/runtime"
"k8s.io/apiserver/pkg/admission"
"k8s.io/apiserver/pkg/authentication/user"
"k8s.io/kubernetes/pkg/apis/core"
"k8s.io/client-go/kubernetes/fake"
api "k8s.io/kubernetes/pkg/apis/core"
"k8s.io/client-go/informers"
"k8s.io/client-go/kubernetes"
"k8s.io/client-go/kubernetes/fake"
"k8s.io/component-base/featuregate"
"k8s.io/kubernetes/pkg/apis/core"
api "k8s.io/kubernetes/pkg/apis/core"
"k8s.io/kubernetes/pkg/controller"
"k8s.io/kubernetes/pkg/features"
@ -352,7 +351,7 @@ func newRuntimeClassForTest(runtimeClassEnabled bool,
if addClient {
var client kubernetes.Interface
if clientObject != nil {
client = fake.NewSimpleClientset(clientObject)
client = fake.NewSimpleClientset(clientObject)
} else {
client = fake.NewSimpleClientset()
}
@ -386,7 +385,7 @@ func TestValidateInitialization(t *testing.T) {
{
name: "runtimeClass enabled, no lister",
expectError: true,
runtimeClass: newRuntimeClassForTest(true, true, false, nil, true, nil,),
runtimeClass: newRuntimeClassForTest(true, true, false, nil, true, nil),
},
{
name: "runtimeClass enabled, no client",
@ -433,7 +432,6 @@ func TestAdmit(t *testing.T) {
false,
nil)
tests := []struct {
name string
expectError bool