github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-01 07:47:56 +00:00
Code Issues Projects Releases Wiki Activity

In pkg/kubectl/describe.go function Matches support unordered types matches.

Browse Source 
The argument of function need to be matched. It did not support unorder matches.
This is a TODO and I fix it.(line 1763 in pkg/kubectl/describe.go)
I use a map to solve it which could compare two types array's difference.
This commit is contained in:
Weixu Zhuang 2015-11-20 11:37:24 -08:00
parent e99243fd12
commit a5a2b94c5f
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
pkg/kubectl/describe.go
View File

@ -1732,13 +1732,18 @@ type typeFunc struct {
}
// Matches returns true when the passed types exactly match the Extra list.
// TODO: allow unordered types to be matched and reorderd.
func (fn typeFunc) Matches(types []reflect.Type) bool {
if len(fn.Extra) != len(types) {
return false
}
// reorder the items in array types and fn.Extra
// convert the type into string and sort them, check if they are matched
varMap := make(map[reflect.Type]bool)
for i := range fn.Extra {
varMap[fn.Extra[i]] = true
}
for i := range types {
if fn.Extra[i] != types[i] {
if _, found := varMap[types[i]]; !found {
return false
}
}