github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2026-07-18 13:57:38 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #133682 from ardaguclu/increase-port-forward-client-timeout

Browse Source 
Increase port-forward broken connection detection client timeout
This commit is contained in:
Kubernetes Prow Robot
2025-08-28 10:49:08 -07:00
committed by GitHub
parent 6fad180fe3 f336f4c75a
commit b260693d18
1 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
test/e2e/kubectl/portforward.go
View File

@@ -641,12 +641,18 @@ var _ = SIGDescribe("Kubectl Port forwarding", func() {
ginkgo.By("Send a http request to verify port-forward working")
client := http.Client{
Timeout: 15 * time.Second,
// As discussed in https://github.com/kubernetes/kubernetes/pull/133682#issuecomment-3228372990,
// 30 second should be sufficient to complete.
Timeout: 30 * time.Second,
}
resp, err := client.Get(fmt.Sprintf("http://127.0.0.1:%d/", cmd.port))
framework.ExpectNoError(err, "couldn't get http response from port-forward")
gomega.Expect(resp.StatusCode).To(gomega.Equal(http.StatusOK), "unexpected status code")
ginkgo.By("Close response body")
err = resp.Body.Close()
framework.ExpectNoError(err, "couldn't close response body")
ginkgo.By("Dialing the local port")
conn, err := net.Dial("tcp", fmt.Sprintf("127.0.0.1:%d", cmd.port))
framework.ExpectNoError(err, "couldn't connect to port %d", cmd.port)
@@ -671,6 +677,10 @@ var _ = SIGDescribe("Kubectl Port forwarding", func() {
resp, err = client.Get(fmt.Sprintf("http://127.0.0.1:%d/", cmd.port))
framework.ExpectNoError(err, "couldn't get http response from port-forward")
gomega.Expect(resp.StatusCode).To(gomega.Equal(http.StatusOK), "unexpected status code")
ginkgo.By("Close response body")
err = resp.Body.Close()
framework.ExpectNoError(err, "couldn't close response body")
})
})
})