mirror of
https://github.com/k3s-io/kubernetes.git
synced 2025-08-11 21:12:07 +00:00
Merge pull request #9608 from markturansky/pv_naming
Changed PVClaimVolumeSource name to match other volume names
This commit is contained in:
commit
b2cc21c2b6
@ -2091,13 +2091,13 @@ func deepCopy_api_VolumeSource(in VolumeSource, out *VolumeSource, c *conversion
|
||||
} else {
|
||||
out.Glusterfs = nil
|
||||
}
|
||||
if in.PersistentVolumeClaimVolumeSource != nil {
|
||||
out.PersistentVolumeClaimVolumeSource = new(PersistentVolumeClaimVolumeSource)
|
||||
if err := deepCopy_api_PersistentVolumeClaimVolumeSource(*in.PersistentVolumeClaimVolumeSource, out.PersistentVolumeClaimVolumeSource, c); err != nil {
|
||||
if in.PersistentVolumeClaim != nil {
|
||||
out.PersistentVolumeClaim = new(PersistentVolumeClaimVolumeSource)
|
||||
if err := deepCopy_api_PersistentVolumeClaimVolumeSource(*in.PersistentVolumeClaim, out.PersistentVolumeClaim, c); err != nil {
|
||||
return err
|
||||
}
|
||||
} else {
|
||||
out.PersistentVolumeClaimVolumeSource = nil
|
||||
out.PersistentVolumeClaim = nil
|
||||
}
|
||||
if in.RBD != nil {
|
||||
out.RBD = new(RBDVolumeSource)
|
||||
|
@ -204,7 +204,7 @@ type VolumeSource struct {
|
||||
// Glusterfs represents a Glusterfs mount on the host that shares a pod's lifetime
|
||||
Glusterfs *GlusterfsVolumeSource `json:"glusterfs,omitempty"`
|
||||
// PersistentVolumeClaimVolumeSource represents a reference to a PersistentVolumeClaim in the same namespace
|
||||
PersistentVolumeClaimVolumeSource *PersistentVolumeClaimVolumeSource `json:"persistentVolumeClaim,omitempty"`
|
||||
PersistentVolumeClaim *PersistentVolumeClaimVolumeSource `json:"persistentVolumeClaim,omitempty"`
|
||||
// RBD represents a Rados Block Device mount on the host that shares a pod's lifetime
|
||||
RBD *RBDVolumeSource `json:"rbd,omitempty"`
|
||||
}
|
||||
|
@ -2314,13 +2314,13 @@ func convert_api_VolumeSource_To_v1_VolumeSource(in *api.VolumeSource, out *Volu
|
||||
} else {
|
||||
out.Glusterfs = nil
|
||||
}
|
||||
if in.PersistentVolumeClaimVolumeSource != nil {
|
||||
out.PersistentVolumeClaimVolumeSource = new(PersistentVolumeClaimVolumeSource)
|
||||
if err := convert_api_PersistentVolumeClaimVolumeSource_To_v1_PersistentVolumeClaimVolumeSource(in.PersistentVolumeClaimVolumeSource, out.PersistentVolumeClaimVolumeSource, s); err != nil {
|
||||
if in.PersistentVolumeClaim != nil {
|
||||
out.PersistentVolumeClaim = new(PersistentVolumeClaimVolumeSource)
|
||||
if err := convert_api_PersistentVolumeClaimVolumeSource_To_v1_PersistentVolumeClaimVolumeSource(in.PersistentVolumeClaim, out.PersistentVolumeClaim, s); err != nil {
|
||||
return err
|
||||
}
|
||||
} else {
|
||||
out.PersistentVolumeClaimVolumeSource = nil
|
||||
out.PersistentVolumeClaim = nil
|
||||
}
|
||||
if in.RBD != nil {
|
||||
out.RBD = new(RBDVolumeSource)
|
||||
@ -4622,13 +4622,13 @@ func convert_v1_VolumeSource_To_api_VolumeSource(in *VolumeSource, out *api.Volu
|
||||
} else {
|
||||
out.Glusterfs = nil
|
||||
}
|
||||
if in.PersistentVolumeClaimVolumeSource != nil {
|
||||
out.PersistentVolumeClaimVolumeSource = new(api.PersistentVolumeClaimVolumeSource)
|
||||
if err := convert_v1_PersistentVolumeClaimVolumeSource_To_api_PersistentVolumeClaimVolumeSource(in.PersistentVolumeClaimVolumeSource, out.PersistentVolumeClaimVolumeSource, s); err != nil {
|
||||
if in.PersistentVolumeClaim != nil {
|
||||
out.PersistentVolumeClaim = new(api.PersistentVolumeClaimVolumeSource)
|
||||
if err := convert_v1_PersistentVolumeClaimVolumeSource_To_api_PersistentVolumeClaimVolumeSource(in.PersistentVolumeClaim, out.PersistentVolumeClaim, s); err != nil {
|
||||
return err
|
||||
}
|
||||
} else {
|
||||
out.PersistentVolumeClaimVolumeSource = nil
|
||||
out.PersistentVolumeClaim = nil
|
||||
}
|
||||
if in.RBD != nil {
|
||||
out.RBD = new(api.RBDVolumeSource)
|
||||
|
@ -2027,13 +2027,13 @@ func deepCopy_v1_VolumeSource(in VolumeSource, out *VolumeSource, c *conversion.
|
||||
} else {
|
||||
out.Glusterfs = nil
|
||||
}
|
||||
if in.PersistentVolumeClaimVolumeSource != nil {
|
||||
out.PersistentVolumeClaimVolumeSource = new(PersistentVolumeClaimVolumeSource)
|
||||
if err := deepCopy_v1_PersistentVolumeClaimVolumeSource(*in.PersistentVolumeClaimVolumeSource, out.PersistentVolumeClaimVolumeSource, c); err != nil {
|
||||
if in.PersistentVolumeClaim != nil {
|
||||
out.PersistentVolumeClaim = new(PersistentVolumeClaimVolumeSource)
|
||||
if err := deepCopy_v1_PersistentVolumeClaimVolumeSource(*in.PersistentVolumeClaim, out.PersistentVolumeClaim, c); err != nil {
|
||||
return err
|
||||
}
|
||||
} else {
|
||||
out.PersistentVolumeClaimVolumeSource = nil
|
||||
out.PersistentVolumeClaim = nil
|
||||
}
|
||||
if in.RBD != nil {
|
||||
out.RBD = new(RBDVolumeSource)
|
||||
|
@ -221,7 +221,7 @@ type VolumeSource struct {
|
||||
// Glusterfs represents a Glusterfs mount on the host that shares a pod's lifetime
|
||||
Glusterfs *GlusterfsVolumeSource `json:"glusterfs,omitempty" description:"Glusterfs volume that will be mounted on the host machine "`
|
||||
// PersistentVolumeClaimVolumeSource represents a reference to a PersistentVolumeClaim in the same namespace
|
||||
PersistentVolumeClaimVolumeSource *PersistentVolumeClaimVolumeSource `json:"persistentVolumeClaim,omitempty" description:"a reference to a PersistentVolumeClaim in the same namespace"`
|
||||
PersistentVolumeClaim *PersistentVolumeClaimVolumeSource `json:"persistentVolumeClaim,omitempty" description:"a reference to a PersistentVolumeClaim in the same namespace"`
|
||||
// RBD represents a Rados Block Device mount on the host that shares a pod's lifetime
|
||||
RBD *RBDVolumeSource `json:"rbd,omitempty" description:"rados block volume that will be mounted on the host machine"`
|
||||
}
|
||||
|
@ -2068,13 +2068,13 @@ func convert_api_VolumeSource_To_v1beta3_VolumeSource(in *api.VolumeSource, out
|
||||
} else {
|
||||
out.Glusterfs = nil
|
||||
}
|
||||
if in.PersistentVolumeClaimVolumeSource != nil {
|
||||
out.PersistentVolumeClaimVolumeSource = new(PersistentVolumeClaimVolumeSource)
|
||||
if err := convert_api_PersistentVolumeClaimVolumeSource_To_v1beta3_PersistentVolumeClaimVolumeSource(in.PersistentVolumeClaimVolumeSource, out.PersistentVolumeClaimVolumeSource, s); err != nil {
|
||||
if in.PersistentVolumeClaim != nil {
|
||||
out.PersistentVolumeClaim = new(PersistentVolumeClaimVolumeSource)
|
||||
if err := convert_api_PersistentVolumeClaimVolumeSource_To_v1beta3_PersistentVolumeClaimVolumeSource(in.PersistentVolumeClaim, out.PersistentVolumeClaim, s); err != nil {
|
||||
return err
|
||||
}
|
||||
} else {
|
||||
out.PersistentVolumeClaimVolumeSource = nil
|
||||
out.PersistentVolumeClaim = nil
|
||||
}
|
||||
if in.RBD != nil {
|
||||
out.RBD = new(RBDVolumeSource)
|
||||
@ -4130,13 +4130,13 @@ func convert_v1beta3_VolumeSource_To_api_VolumeSource(in *VolumeSource, out *api
|
||||
} else {
|
||||
out.Glusterfs = nil
|
||||
}
|
||||
if in.PersistentVolumeClaimVolumeSource != nil {
|
||||
out.PersistentVolumeClaimVolumeSource = new(api.PersistentVolumeClaimVolumeSource)
|
||||
if err := convert_v1beta3_PersistentVolumeClaimVolumeSource_To_api_PersistentVolumeClaimVolumeSource(in.PersistentVolumeClaimVolumeSource, out.PersistentVolumeClaimVolumeSource, s); err != nil {
|
||||
if in.PersistentVolumeClaim != nil {
|
||||
out.PersistentVolumeClaim = new(api.PersistentVolumeClaimVolumeSource)
|
||||
if err := convert_v1beta3_PersistentVolumeClaimVolumeSource_To_api_PersistentVolumeClaimVolumeSource(in.PersistentVolumeClaim, out.PersistentVolumeClaim, s); err != nil {
|
||||
return err
|
||||
}
|
||||
} else {
|
||||
out.PersistentVolumeClaimVolumeSource = nil
|
||||
out.PersistentVolumeClaim = nil
|
||||
}
|
||||
if in.RBD != nil {
|
||||
out.RBD = new(api.RBDVolumeSource)
|
||||
|
@ -2027,13 +2027,13 @@ func deepCopy_v1beta3_VolumeSource(in VolumeSource, out *VolumeSource, c *conver
|
||||
} else {
|
||||
out.Glusterfs = nil
|
||||
}
|
||||
if in.PersistentVolumeClaimVolumeSource != nil {
|
||||
out.PersistentVolumeClaimVolumeSource = new(PersistentVolumeClaimVolumeSource)
|
||||
if err := deepCopy_v1beta3_PersistentVolumeClaimVolumeSource(*in.PersistentVolumeClaimVolumeSource, out.PersistentVolumeClaimVolumeSource, c); err != nil {
|
||||
if in.PersistentVolumeClaim != nil {
|
||||
out.PersistentVolumeClaim = new(PersistentVolumeClaimVolumeSource)
|
||||
if err := deepCopy_v1beta3_PersistentVolumeClaimVolumeSource(*in.PersistentVolumeClaim, out.PersistentVolumeClaim, c); err != nil {
|
||||
return err
|
||||
}
|
||||
} else {
|
||||
out.PersistentVolumeClaimVolumeSource = nil
|
||||
out.PersistentVolumeClaim = nil
|
||||
}
|
||||
if in.RBD != nil {
|
||||
out.RBD = new(RBDVolumeSource)
|
||||
|
@ -221,7 +221,7 @@ type VolumeSource struct {
|
||||
// Glusterfs represents a Glusterfs mount on the host that shares a pod's lifetime
|
||||
Glusterfs *GlusterfsVolumeSource `json:"glusterfs,omitempty" description:"Glusterfs volume that will be mounted on the host machine "`
|
||||
// PersistentVolumeClaimVolumeSource represents a reference to a PersistentVolumeClaim in the same namespace
|
||||
PersistentVolumeClaimVolumeSource *PersistentVolumeClaimVolumeSource `json:"persistentVolumeClaim,omitempty" description:"a reference to a PersistentVolumeClaim in the same namespace"`
|
||||
PersistentVolumeClaim *PersistentVolumeClaimVolumeSource `json:"persistentVolumeClaim,omitempty" description:"a reference to a PersistentVolumeClaim in the same namespace"`
|
||||
// RBD represents a Rados Block Device mount on the host that shares a pod's lifetime
|
||||
RBD *RBDVolumeSource `json:"rbd,omitempty" description:"rados block volume that will be mounted on the host machine"`
|
||||
}
|
||||
|
@ -338,9 +338,9 @@ func validateSource(source *api.VolumeSource) errs.ValidationErrorList {
|
||||
numVolumes++
|
||||
allErrs = append(allErrs, validateGlusterfs(source.Glusterfs).Prefix("glusterfs")...)
|
||||
}
|
||||
if source.PersistentVolumeClaimVolumeSource != nil {
|
||||
if source.PersistentVolumeClaim != nil {
|
||||
numVolumes++
|
||||
allErrs = append(allErrs, validatePersistentClaimVolumeSource(source.PersistentVolumeClaimVolumeSource).Prefix("persistentVolumeClaim")...)
|
||||
allErrs = append(allErrs, validatePersistentClaimVolumeSource(source.PersistentVolumeClaim).Prefix("persistentVolumeClaim")...)
|
||||
}
|
||||
if source.RBD != nil {
|
||||
numVolumes++
|
||||
|
@ -48,13 +48,13 @@ func (plugin *persistentClaimPlugin) Name() string {
|
||||
}
|
||||
|
||||
func (plugin *persistentClaimPlugin) CanSupport(spec *volume.Spec) bool {
|
||||
return spec.VolumeSource.PersistentVolumeClaimVolumeSource != nil
|
||||
return spec.VolumeSource.PersistentVolumeClaim != nil
|
||||
}
|
||||
|
||||
func (plugin *persistentClaimPlugin) NewBuilder(spec *volume.Spec, pod *api.Pod, opts volume.VolumeOptions, mounter mount.Interface) (volume.Builder, error) {
|
||||
claim, err := plugin.host.GetKubeClient().PersistentVolumeClaims(pod.Namespace).Get(spec.VolumeSource.PersistentVolumeClaimVolumeSource.ClaimName)
|
||||
claim, err := plugin.host.GetKubeClient().PersistentVolumeClaims(pod.Namespace).Get(spec.VolumeSource.PersistentVolumeClaim.ClaimName)
|
||||
if err != nil {
|
||||
glog.Errorf("Error finding claim: %+v\n", spec.VolumeSource.PersistentVolumeClaimVolumeSource.ClaimName)
|
||||
glog.Errorf("Error finding claim: %+v\n", spec.VolumeSource.PersistentVolumeClaim.ClaimName)
|
||||
return nil, err
|
||||
}
|
||||
|
||||
|
@ -52,7 +52,7 @@ func TestCanSupport(t *testing.T) {
|
||||
if plug.Name() != "kubernetes.io/persistent-claim" {
|
||||
t.Errorf("Wrong name: %s", plug.Name())
|
||||
}
|
||||
if !plug.CanSupport(&volume.Spec{Name: "foo", VolumeSource: api.VolumeSource{PersistentVolumeClaimVolumeSource: &api.PersistentVolumeClaimVolumeSource{}}}) {
|
||||
if !plug.CanSupport(&volume.Spec{Name: "foo", VolumeSource: api.VolumeSource{PersistentVolumeClaim: &api.PersistentVolumeClaimVolumeSource{}}}) {
|
||||
t.Errorf("Expected true")
|
||||
}
|
||||
if plug.CanSupport(&volume.Spec{VolumeSource: api.VolumeSource{GitRepo: &api.GitRepoVolumeSource{}}}) {
|
||||
@ -99,7 +99,7 @@ func TestNewBuilder(t *testing.T) {
|
||||
},
|
||||
},
|
||||
podVolume: api.VolumeSource{
|
||||
PersistentVolumeClaimVolumeSource: &api.PersistentVolumeClaimVolumeSource{
|
||||
PersistentVolumeClaim: &api.PersistentVolumeClaimVolumeSource{
|
||||
ReadOnly: false,
|
||||
ClaimName: "claimA",
|
||||
},
|
||||
@ -137,7 +137,7 @@ func TestNewBuilder(t *testing.T) {
|
||||
},
|
||||
},
|
||||
podVolume: api.VolumeSource{
|
||||
PersistentVolumeClaimVolumeSource: &api.PersistentVolumeClaimVolumeSource{
|
||||
PersistentVolumeClaim: &api.PersistentVolumeClaimVolumeSource{
|
||||
ReadOnly: false,
|
||||
ClaimName: "claimB",
|
||||
},
|
||||
@ -175,7 +175,7 @@ func TestNewBuilder(t *testing.T) {
|
||||
},
|
||||
},
|
||||
podVolume: api.VolumeSource{
|
||||
PersistentVolumeClaimVolumeSource: &api.PersistentVolumeClaimVolumeSource{
|
||||
PersistentVolumeClaim: &api.PersistentVolumeClaimVolumeSource{
|
||||
ReadOnly: false,
|
||||
ClaimName: "claimA",
|
||||
},
|
||||
@ -218,7 +218,7 @@ func TestNewBuilder(t *testing.T) {
|
||||
},
|
||||
},
|
||||
podVolume: api.VolumeSource{
|
||||
PersistentVolumeClaimVolumeSource: &api.PersistentVolumeClaimVolumeSource{
|
||||
PersistentVolumeClaim: &api.PersistentVolumeClaimVolumeSource{
|
||||
ReadOnly: false,
|
||||
ClaimName: "claimA",
|
||||
},
|
||||
@ -287,7 +287,7 @@ func TestNewBuilderClaimNotBound(t *testing.T) {
|
||||
},
|
||||
}
|
||||
podVolume := api.VolumeSource{
|
||||
PersistentVolumeClaimVolumeSource: &api.PersistentVolumeClaimVolumeSource{
|
||||
PersistentVolumeClaim: &api.PersistentVolumeClaimVolumeSource{
|
||||
ReadOnly: false,
|
||||
ClaimName: "claimC",
|
||||
},
|
||||
|
Loading…
Reference in New Issue
Block a user