Merge pull request #123158 from AkihiroSuda/nodeconditiontype-godoc

core/v1: remove comment about non-existing constants
This commit is contained in:
Kubernetes Prow Robot 2024-02-15 08:16:20 -08:00 committed by GitHub
commit b65508b477
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 3 additions and 5 deletions

View File

@ -4900,9 +4900,8 @@ const (
// NodeConditionType defines node's condition // NodeConditionType defines node's condition
type NodeConditionType string type NodeConditionType string
// These are valid conditions of node. Currently, we don't have enough information to decide // These are valid but not exhaustive conditions of node. A cloud provider may set a condition not listed here.
// node condition. In the future, we will add more. The proposed set of conditions are: // Relevant events contain "NodeReady", "NodeNotReady", "NodeSchedulable", and "NodeNotSchedulable".
// NodeReady, NodeReachable
const ( const (
// NodeReady means kubelet is healthy and ready to accept pods. // NodeReady means kubelet is healthy and ready to accept pods.
NodeReady NodeConditionType = "Ready" NodeReady NodeConditionType = "Ready"

View File

@ -5867,8 +5867,7 @@ const (
type NodeConditionType string type NodeConditionType string
// These are valid but not exhaustive conditions of node. A cloud provider may set a condition not listed here. // These are valid but not exhaustive conditions of node. A cloud provider may set a condition not listed here.
// The built-in set of conditions are: // Relevant events contain "NodeReady", "NodeNotReady", "NodeSchedulable", and "NodeNotSchedulable".
// NodeReachable, NodeLive, NodeReady, NodeSchedulable, NodeRunnable.
const ( const (
// NodeReady means kubelet is healthy and ready to accept pods. // NodeReady means kubelet is healthy and ready to accept pods.
NodeReady NodeConditionType = "Ready" NodeReady NodeConditionType = "Ready"