github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-30 15:05:27 +00:00
Code Issues Projects Releases Wiki Activity

logs: work around logcheck

Browse Source 
logcheck complains:
Additional arguments to ErrorS should always be Key Value pairs. Please check if there is any key or value missing.

That check is intentional, but not applicable here. The check can be worked
around by calling the functions through variables.
This commit is contained in:
Patrick Ohly 2021-11-30 16:29:32 +01:00
parent 072859c967
commit b8501fc10b
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
test/integration/logs/benchmark/common_test.go
View File

@ -70,10 +70,17 @@ func printf(item logMessage) {
}
}
// These variables are a workaround for logcheck complaining about the dynamic
// parameters.
var (
errorS = klog.ErrorS
infoS = klog.InfoS
)
func prints(item logMessage) {
if item.isError {
klog.ErrorS(item.err, item.msg, item.kvs...)
errorS(item.err, item.msg, item.kvs...)
} else {
klog.InfoS(item.msg, item.kvs...)
infoS(item.msg, item.kvs...)
}
}