Merge pull request #91213 from dims/support-for-banning-incompatible-deps-klog-v1

Support for banning incompatible dependencies - start with klog v1
This commit is contained in:
Kubernetes Prow Robot 2020-05-18 13:34:17 -07:00 committed by GitHub
commit ba2855eaa5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -58,6 +58,23 @@ case "${1:-}" in
;;
esac
# let us log all errors before we exit
rc=0
# List of dependencies we need to avoid dragging back into kubernetes/kubernetes
forbidden_repos=(
"k8s.io/klog" # we have switched to klog v2, so avoid klog v1
)
for forbidden_repo in "${forbidden_repos[@]}"; do
deps_on_forbidden=$(go mod graph | grep " ${forbidden_repo}@" || echo "")
if [ -n "${deps_on_forbidden}" ]; then
kube::log::error "The following have transitive dependencies on ${forbidden_repo}, which is not allowed:"
echo "${deps_on_forbidden}"
echo ""
rc=1
fi
done
outdated=$(go list -m -json all | jq -r "
select(.Replace.Version != null) |
select(.Version != .Replace.Version) |
@ -89,8 +106,8 @@ if [[ -n "${unused}" ]]; then
fi
if [[ -n "${unused}${outdated}" ]]; then
exit 1
rc=1
fi
echo "All pinned versions of checked dependencies match their preferred version."
exit 0
exit $rc