github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-22 11:21:47 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #114834 from chendave/regression

Browse Source 
kubeadm: unittest might run as non-root
This commit is contained in:
Kubernetes Prow Robot 2023-01-05 00:51:59 -08:00 committed by GitHub
commit bc61d70055
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 15 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
cmd/kubeadm/app/cmd/upgrade/common_test.go
View File

@ -72,18 +72,20 @@ func TestEnforceRequirements(t *testing.T) {
}
tcases := []struct {
name string
newK8sVersion string
dryRun bool
flags applyPlanFlags
expectedErr string
name string
newK8sVersion string
dryRun bool
flags applyPlanFlags
expectedErr string
expectedErrNonRoot string
}{
{
name: "Fail pre-flight check",
flags: applyPlanFlags{
kubeConfigPath: fullPath,
},
expectedErr: "ERROR CoreDNSUnsupportedPlugins",
expectedErr: "ERROR CoreDNSUnsupportedPlugins",
expectedErrNonRoot: "user is not running as", // user is not running as (root || administrator)
},
{
name: "Bogus preflight check specify all with individual check",
@ -109,8 +111,13 @@ func TestEnforceRequirements(t *testing.T) {
t.Error("Expected error, but got success")
}
if err != nil && !strings.Contains(err.Error(), tt.expectedErr) {
t.Fatalf("enforceRequirements returned unexpected error, expected: %s, got %v", tt.expectedErr, err)
expErr := tt.expectedErr
// pre-flight check expects the user to be root, so the root and non-root should hit different errors
if os.Getuid() != 0 && len(tt.expectedErrNonRoot) != 0 {
expErr = tt.expectedErrNonRoot
}
if err != nil && !strings.Contains(err.Error(), expErr) {
t.Fatalf("enforceRequirements returned unexpected error, expected: %s, got %v", expErr, err)
}
})