github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-29 22:46:12 +00:00
Code Issues Projects Releases Wiki Activity

Fix flaky legacy pod autoscaler test

Browse Source 
The reactor in runTest is set to catch all actions, but eventually it
only handles CreateAction without checking action type which might fail
sometimes when Patch arrives. This fix ensures we handle only the
CreateAction.
This commit is contained in:
Maciej Szulik 2019-04-05 11:59:23 +02:00
parent 84b561033e
commit bcfd48c29e
No known key found for this signature in database
GPG Key ID: F15E55D276FA84C4
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
pkg/controller/podautoscaler/legacy_horizontal_test.go
View File

@ -472,7 +472,11 @@ func (tc *legacyTestCase) runTest(t *testing.T) {
if tc.finished {
return true, &v1.Event{}, nil
}
obj := action.(core.CreateAction).GetObject().(*v1.Event)
create, ok := action.(core.CreateAction)
if !ok {
return false, nil, nil
}
obj := create.GetObject().(*v1.Event)
if tc.verifyEvents {
switch obj.Reason {
case "SuccessfulRescale":