github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-23 19:56:01 +00:00
Code Issues Projects Releases Wiki Activity

Instrument transformer.go with latency metrics.

Browse Source
This commit is contained in:
immutablet 2018-03-16 14:25:26 -07:00
parent 04a6613fb5
commit bfcb3cd91f
2 changed files with 16 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
staging/src/k8s.io/apiserver/pkg/storage/value/metrics.go
View File

@ -23,16 +23,16 @@ import (
"github.com/prometheus/client_golang/prometheus"
)
const (
valueSubsystem = "value"
)
var (
TransformerOperationalLatencies = prometheus.NewSummaryVec(
prometheus.SummaryOpts{
Subsystem: valueSubsystem,
Name: "apiserver_storage_transformation_latency_microseconds",
Help: "Latency in microseconds of value transformation operations.",
transformerLatencies = prometheus.NewHistogramVec(
prometheus.HistogramOpts{
Namespace: "apiserver",
Subsystem: "storage",
Name: "transformation_latencies_microseconds",
Help: "Latencies in microseconds of value transformation operations.",
// In-process transformations (ex. AES CBC) complete on the order of 20 microseconds. However, when
// external KMS is involved latencies may climb into milliseconds.
Buckets: prometheus.ExponentialBuckets(5, 2, 14),
},
[]string{"transformation_type"},
)
@ -42,14 +42,16 @@ var registerMetrics sync.Once
func RegisterMetrics() {
registerMetrics.Do(func() {
prometheus.MustRegister(TransformerOperationalLatencies)
prometheus.MustRegister(transformerLatencies)
})
}
func RecordTransformation(transformationType string, start time.Time) {
TransformerOperationalLatencies.WithLabelValues(transformationType).Observe(float64(sinceInMicroseconds(start)))
since := sinceInMicroseconds(start)
transformerLatencies.WithLabelValues(transformationType).Observe(float64(since))
}
func sinceInMicroseconds(start time.Time) time.Duration {
return time.Since(start) / time.Microsecond
func sinceInMicroseconds(start time.Time) int64 {
elapsedNanoseconds := time.Since(start).Nanoseconds()
return elapsedNanoseconds / int64(time.Microsecond)
}

3
test/integration/master/transformation_testcase.go
View File

@ -48,7 +48,7 @@ const (
encryptionConfigFileName = "encryption.conf"
testNamespace = "secret-encryption-test"
testSecret = "test-secret"
latencySummaryMetricsFamily = "value_apiserver_storage_transformation_latency_microseconds"
latencySummaryMetricsFamily = "apiserver_storage_transformation_latencies_microseconds"
)
type unSealSecret func(cipherText []byte, ctx value.Context, config encryptionconfig.ProviderConfig) ([]byte, error)
@ -248,7 +248,6 @@ func (e *transformTest) printMetrics() error {
}
metricsOfInterest := []string{latencySummaryMetricsFamily}
for _, mf := range metrics {
if contains(metricsOfInterest, *mf.Name) {
for _, metric := range mf.GetMetric() {