github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-29 06:27:05 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #32049 from smarterclayton/incorrect_pointer

Browse Source 
Automatic merge from submit-queue

generated DeepCopy without a function on a struct pointer is wrong

in and out are both pointers to pointers, so *in has to be cast to
*Type, not Type.

@sttts hit this while debugging something else (most everything should be generated, but in this case the type is wrong)
This commit is contained in:
Kubernetes Submit Queue 2016-09-06 03:14:03 -07:00 committed by GitHub
commit c79a07f21f
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cmd/libs/go2idl/deepcopy-gen/generators/deepcopy.go
View File

@ -609,7 +609,7 @@ func (g *genDeepCopy) doPointer(t *types.Type, sw *generator.SnippetWriter) {
sw.Do("if newVal, err := c.DeepCopy(*in); err != nil {\n", nil)
sw.Do("return err\n", nil)
sw.Do("} else {\n", nil)
sw.Do("*out = newVal.($.|raw$)\n", t.Elem)
sw.Do("*out = newVal.(*$.|raw$)\n", t.Elem)
sw.Do("}\n", nil)
}
}