github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-05 10:19:50 +00:00
Code Issues Projects Releases Wiki Activity

updated tests to prevent false positive

Browse Source 
one test also proved it did not call the internet
but this was not fool proof as it did not return a string
and thus could be called with something expecting to fail.
This commit is contained in:
Marek Counts 2019-06-07 08:36:49 -04:00
parent aad2b573c6
commit c8045049f3
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
cmd/kubeadm/app/util/version_test.go
View File

@ -52,7 +52,7 @@ func TestValidVersion(t *testing.T) {
for _, s := range validVersions { for _, s := range validVersions {
t.Run(s, func(t *testing.T) { t.Run(s, func(t *testing.T) {
fileFetcher := func(url string, timeout time.Duration) (string, error) { fileFetcher := func(url string, timeout time.Duration) (string, error) {
return "", errors.New("Should not make internet call") return "", errors.New("should not make internet call")
} }
ver, err := kubernetesReleaseVersion(s, fileFetcher) ver, err := kubernetesReleaseVersion(s, fileFetcher)
t.Log("Valid: ", s, ver, err) t.Log("Valid: ", s, ver, err)
@ -77,7 +77,7 @@ func TestInvalidVersion(t *testing.T) {
for _, s := range invalidVersions { for _, s := range invalidVersions {
t.Run(s, func(t *testing.T) { t.Run(s, func(t *testing.T) {
fileFetcher := func(url string, timeout time.Duration) (string, error) { fileFetcher := func(url string, timeout time.Duration) (string, error) {
return "", errors.New("Should not make internet call") return "should not make internet calls", errors.New("should not make internet call")
} }
ver, err := kubernetesReleaseVersion(s, fileFetcher) ver, err := kubernetesReleaseVersion(s, fileFetcher)
t.Log("Invalid: ", s, ver, err) t.Log("Invalid: ", s, ver, err)
@ -100,7 +100,7 @@ func TestValidConvenientForUserVersion(t *testing.T) {
for _, s := range validVersions { for _, s := range validVersions {
t.Run(s, func(t *testing.T) { t.Run(s, func(t *testing.T) {
fileFetcher := func(url string, timeout time.Duration) (string, error) { fileFetcher := func(url string, timeout time.Duration) (string, error) {
return "", errors.New("Should not make internet call") return "", errors.New("should not make internet call")
} }
ver, err := kubernetesReleaseVersion(s, fileFetcher) ver, err := kubernetesReleaseVersion(s, fileFetcher)
t.Log("Valid: ", s, ver, err) t.Log("Valid: ", s, ver, err)