github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-31 23:37:01 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #25244 from smarterclayton/trace_alloc

Browse Source 
Trace.Step() performs an unnecessary alloc
This commit is contained in:
Robert Bailey 2016-05-06 13:43:24 -07:00
commit caf6f06f19
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
pkg/util/trace.go
View File

@ -32,15 +32,19 @@ type traceStep struct {
type Trace struct { type Trace struct {
name string name string
startTime time.Time startTime time.Time
steps []*traceStep steps []traceStep
} }
func NewTrace(name string) *Trace { func NewTrace(name string) *Trace {
return &Trace{name, time.Now(), make([]*traceStep, 0)} return &Trace{name, time.Now(), nil}
} }
func (t *Trace) Step(msg string) { func (t *Trace) Step(msg string) {
t.steps = append(t.steps, &traceStep{time.Now(), msg}) if t.steps == nil {
// traces almost always have less than 6 steps, do this to avoid more than a single allocation
t.steps = make([]traceStep, 0, 6)
}
t.steps = append(t.steps, traceStep{time.Now(), msg})
} }
func (t *Trace) Log() { func (t *Trace) Log() {