mirror of
https://github.com/k3s-io/kubernetes.git
synced 2025-07-23 03:41:45 +00:00
Fix slice type comparison bug
This commit is contained in:
parent
333eb833e5
commit
ccbdf041a2
@ -747,6 +747,11 @@ func TestAddImagePullSecrets(t *testing.T) {
|
||||
{Name: "bar"},
|
||||
},
|
||||
}
|
||||
originalSA := sa.DeepCopy()
|
||||
expected := []api.LocalObjectReference{
|
||||
{Name: "foo"},
|
||||
{Name: "bar"},
|
||||
}
|
||||
// Add the default service account for the ns with a secret reference into the cache
|
||||
informerFactory.Core().V1().ServiceAccounts().Informer().GetStore().Add(sa)
|
||||
|
||||
@ -757,10 +762,10 @@ func TestAddImagePullSecrets(t *testing.T) {
|
||||
t.Errorf("Unexpected error: %v", err)
|
||||
}
|
||||
|
||||
assert.EqualValues(t, sa.ImagePullSecrets, pod.Spec.ImagePullSecrets, "expected %v, got %v", sa.ImagePullSecrets, pod.Spec.ImagePullSecrets)
|
||||
assert.EqualValues(t, expected, pod.Spec.ImagePullSecrets, "expected %v, got %v", expected, pod.Spec.ImagePullSecrets)
|
||||
|
||||
pod.Spec.ImagePullSecrets[1] = api.LocalObjectReference{Name: "baz"}
|
||||
if reflect.DeepEqual(sa.ImagePullSecrets, pod.Spec.ImagePullSecrets) {
|
||||
if !reflect.DeepEqual(originalSA, sa) {
|
||||
t.Errorf("accidentally mutated the ServiceAccount.ImagePullSecrets: %v", sa.ImagePullSecrets)
|
||||
}
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user