github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-28 05:57:25 +00:00
Code Issues Projects Releases Wiki Activity

Fix slice type comparison bug

Browse Source
This commit is contained in:
Jordan Liggitt 2021-08-18 11:30:34 -04:00
parent 333eb833e5
commit ccbdf041a2
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
plugin/pkg/admission/serviceaccount/admission_test.go
View File

@ -747,6 +747,11 @@ func TestAddImagePullSecrets(t *testing.T) {
{Name: "bar"}, {Name: "bar"},
}, },
} }
originalSA := sa.DeepCopy()
expected := []api.LocalObjectReference{
{Name: "foo"},
{Name: "bar"},
}
// Add the default service account for the ns with a secret reference into the cache // Add the default service account for the ns with a secret reference into the cache
informerFactory.Core().V1().ServiceAccounts().Informer().GetStore().Add(sa) informerFactory.Core().V1().ServiceAccounts().Informer().GetStore().Add(sa)
@ -757,10 +762,10 @@ func TestAddImagePullSecrets(t *testing.T) {
t.Errorf("Unexpected error: %v", err) t.Errorf("Unexpected error: %v", err)
} }
assert.EqualValues(t, sa.ImagePullSecrets, pod.Spec.ImagePullSecrets, "expected %v, got %v", sa.ImagePullSecrets, pod.Spec.ImagePullSecrets) assert.EqualValues(t, expected, pod.Spec.ImagePullSecrets, "expected %v, got %v", expected, pod.Spec.ImagePullSecrets)
pod.Spec.ImagePullSecrets[1] = api.LocalObjectReference{Name: "baz"} pod.Spec.ImagePullSecrets[1] = api.LocalObjectReference{Name: "baz"}
if reflect.DeepEqual(sa.ImagePullSecrets, pod.Spec.ImagePullSecrets) { if !reflect.DeepEqual(originalSA, sa) {
t.Errorf("accidentally mutated the ServiceAccount.ImagePullSecrets: %v", sa.ImagePullSecrets) t.Errorf("accidentally mutated the ServiceAccount.ImagePullSecrets: %v", sa.ImagePullSecrets)
} }
} }