Address comments during Review

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
This commit is contained in:
Davanum Srinivas 2024-01-09 15:34:37 -05:00
parent b7012da2ad
commit ce263d8828
No known key found for this signature in database
GPG Key ID: 80D83A796103BF59
2 changed files with 4 additions and 21 deletions

View File

@ -31,7 +31,10 @@ unset CDPATH
# they can explicitly set GO111MODULE=on
export GO111MODULE=off
if [[ "${KUBE_PROVIDERLESS:-"off"}" == "on" ]]; then
# FIXME(dims): Note that here we assume that if GOFLAGS are already set we
# leave them as-is and not try to add providerless to it. So if you
# really need to set your own GOFLAGS, ensure you add "providerless" explicitly
if [[ "${KUBE_PROVIDERLESS:-"n"}" == "y" ]]; then
export GOFLAGS=${GOFLAGS:-"-tags=providerless"}
fi

View File

@ -1,20 +0,0 @@
//go:build providerless
// +build providerless
/*
Copyright 2024 The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package e2e