github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-23 11:50:44 +00:00
Code Issues Projects Releases Wiki Activity

Node e2e - Fix issue where error in scp is not return. Fixes #26435

Browse Source
This commit is contained in:
Phillip Wittrock 2016-05-27 10:33:23 -07:00
parent 70a71990d4
commit d051f0b7cd
1 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
test/e2e_node/e2e_remote.go
View File

@ -162,21 +162,21 @@ func RunRemote(archive string, host string, cleanup bool, junitFileNumber int) (
fmt.Sprintf("tar -xzvf ./%s", archiveName),
fmt.Sprintf("timeout -k 30s %ds ./e2e_node.test --logtostderr --v 2 --build-services=false --stop-services=%t --node-name=%s --report-dir=%s/results --junit-file-number=%d", *testTimeoutSeconds, cleanup, host, tmp, junitFileNumber),
)
aggErr := []error{}
glog.Infof("Starting tests on %s", host)
output, err := RunSshCommand("ssh", host, "--", "sh", "-c", cmd)
if err != nil {
scpErr := getTestArtifacts(host, tmp)
// Return both the testing and scp error
if scpErr != nil {
return "", utilerrors.NewAggregate([]error{err, scpErr})
}
return "", err
aggErr = append(aggErr, err)
}
err = getTestArtifacts(host, tmp)
return output, nil
glog.Infof("Copying test artifacts from %s", host)
scpErr := getTestArtifacts(host, tmp)
if scpErr != nil {
aggErr = append(aggErr, scpErr)
}
return output, utilerrors.NewAggregate(aggErr)
}
func getTestArtifacts(host, testDir string) error {