github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-21 10:51:29 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #80785 from oomichi/add-expectequal-hack

Browse Source 
Add code check for framework.ExpectEqual()
This commit is contained in:
Kubernetes Prow Robot 2019-08-13 14:16:19 -07:00 committed by GitHub
commit d2eecfe2ef
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 23 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
hack/verify-test-code.sh
View File

@ -42,6 +42,15 @@ do
fi
done
errors_expect_equal=()
for file in "${all_e2e_files[@]}"
do
if grep -E "Expect\(.*\)\.To\((gomega\.Equal|Equal)" "${file}" > /dev/null
then
errors_expect_equal+=( "${file}" )
fi
done
if [ ${#errors_expect_no_error[@]} -ne 0 ]; then
{
echo "Errors:"
@ -70,4 +79,18 @@ if [ ${#errors_expect_error[@]} -ne 0 ]; then
exit 1
fi
if [ ${#errors_expect_equal[@]} -ne 0 ]; then
{
echo "Errors:"
for err in "${errors_expect_equal[@]}"; do
echo "$err"
done
echo
echo 'The above files need to use framework.ExpectEqual(foo, bar) instead of '
echo 'Expect(foo).To(Equal(bar)) or gomega.Expect(foo).To(gomega.Equal(bar))'
echo
} >&2
exit 1
fi
echo 'Congratulations! All e2e test source files are valid.'