mirror of
https://github.com/k3s-io/kubernetes.git
synced 2025-07-24 04:06:03 +00:00
Merge pull request #57990 from krmayankk/disrupt
Automatic merge from submit-queue (batch tested with PRs 57973, 57990). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix RunAsUserId validation Use validation.IsValidUserID to properly check for valid UserId in RunAsUser field of SecurityContext. release-note NONE
This commit is contained in:
commit
d32624ab85
@ -4813,8 +4813,8 @@ func ValidateSecurityContext(sc *core.SecurityContext, fldPath *field.Path) fiel
|
|||||||
}
|
}
|
||||||
|
|
||||||
if sc.RunAsUser != nil {
|
if sc.RunAsUser != nil {
|
||||||
if *sc.RunAsUser < 0 {
|
for _, msg := range validation.IsValidUserID(*sc.RunAsUser) {
|
||||||
allErrs = append(allErrs, field.Invalid(fldPath.Child("runAsUser"), *sc.RunAsUser, isNegativeErrorMsg))
|
allErrs = append(allErrs, field.Invalid(fldPath.Child("runAsUser"), *sc.RunAsUser, msg))
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -11752,7 +11752,7 @@ func TestValidateSecurityContext(t *testing.T) {
|
|||||||
"negative RunAsUser": {
|
"negative RunAsUser": {
|
||||||
sc: negativeRunAsUser,
|
sc: negativeRunAsUser,
|
||||||
errorType: "FieldValueInvalid",
|
errorType: "FieldValueInvalid",
|
||||||
errorDetail: isNegativeErrorMsg,
|
errorDetail: "must be between",
|
||||||
},
|
},
|
||||||
}
|
}
|
||||||
for k, v := range errorCases {
|
for k, v := range errorCases {
|
||||||
|
Loading…
Reference in New Issue
Block a user