github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-08 11:38:15 +00:00
Code Issues Projects Releases Wiki Activity

integration: remove special verbosity for garbagecollector and graph_builder

Browse Source 
The setting for garbagecollector was added 7 years ago in 9ac91e5172 for
"debugging gc".  graph_builder was added 6 years in a98801c1 when restoring the
-vmodule parameter after some temporary removal, without an explanation.

It seems safe to assume that the garbage collector has been debugged
sufficiently...

These defaults cause performance overhead:
- Enabling -vmodule slows down all log calls because checking verbosity
  cannot take a simpler fast path.
- The amount of log output is much higher for those files.

The amount of log data also caused test output to get truncated, removing the
actual test failure explanation.
This commit is contained in:
Patrick Ohly 2023-05-23 21:13:39 +02:00
parent 828495bcc0
commit d459b4429f
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hack/make-rules/test-integration.sh
View File

@ -41,7 +41,7 @@ KUBE_TIMEOUT=${KUBE_TIMEOUT:--timeout=600s}
LOG_LEVEL=${LOG_LEVEL:-2}
KUBE_TEST_ARGS=${KUBE_TEST_ARGS:-}
# Default glog module settings.
KUBE_TEST_VMODULE=${KUBE_TEST_VMODULE:-"garbagecollector*=6,graph_builder*=6"}
KUBE_TEST_VMODULE=${KUBE_TEST_VMODULE:-""}
kube::test::find_integration_test_dirs() {
(