github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-09-15 06:01:50 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #27672 from quinton-hoole/2016-06-18-return-error-on-dnsprovider-error

Browse Source 
Automatic merge from submit-queue

Return error not empty list when dnsprovider returns an error.

Without this change, we return an empty list, instead of the error from the underlying dns provider, which makes debugging hard.
This commit is contained in:
k8s-merge-robot
2016-06-18 17:08:06 -07:00
committed by GitHub
parent 6b14e0f226 30afb6b072
commit d526f82f2f
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
federation/pkg/dnsprovider/providers/google/clouddns/zones.go
View File

@@ -29,7 +29,7 @@ type Zones struct {
func (zones Zones) List() ([]dnsprovider.Zone, error) {
response, err := zones.impl.List(zones.project()).Do()
if err != nil {
return []dnsprovider.Zone{}, nil
return nil, err
}
managedZones := response.ManagedZones()
zoneList := make([]dnsprovider.Zone, len(managedZones))