github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-10 20:42:26 +00:00
Code Issues Projects Releases Wiki Activity

DRA resourceslice controller: use preconditions for Delete

Browse Source 
It's better to verify UID and ResourceVersion of the ResourceSlice that we want
to delete. If anything changed, the decision to remove it might not apply
anymore and we need to check again.
This commit is contained in:
Patrick Ohly 2024-10-26 20:48:54 +02:00
parent a6d180c7d3
commit d94752ebc8
1 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
staging/src/k8s.io/dynamic-resource-allocation/resourceslice/resourceslicecontroller.go
View File

@ -605,8 +605,22 @@ func (c *Controller) syncPool(ctx context.Context, poolName string) error {
// Remove stale slices.
for _, slice := range obsoleteSlices {
logger.V(5).Info("Deleting obsolete resource slice", "slice", klog.KObj(slice))
if err := c.kubeClient.ResourceV1alpha3().ResourceSlices().Delete(ctx, slice.Name, metav1.DeleteOptions{}); err != nil && !apierrors.IsNotFound(err) {
options := metav1.DeleteOptions{
Preconditions: &metav1.Preconditions{
UID: &slice.UID,
ResourceVersion: &slice.ResourceVersion,
},
}
// It can happen that we sync again shortly after deleting a
// slice and before the slice gets removed from the informer
// cache. The MutationCache can't help here because it does not
// track pending deletes.
//
// If this happens, we get a "not found error" and nothing
// changes on the server. The only downside is the extra API
// call. This isn't as bad as extra creates.
logger.V(5).Info("Deleting obsolete resource slice", "slice", klog.KObj(slice), "deleteOptions", options)
if err := c.kubeClient.ResourceV1alpha3().ResourceSlices().Delete(ctx, slice.Name, options); err != nil && !apierrors.IsNotFound(err) {
return fmt.Errorf("delete resource slice: %w", err)
}
}