github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-25 20:53:33 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #111949 from chymy/kubeadm-version-test

Browse Source 
kubeadm: add test cases for version_test.go
This commit is contained in:
Kubernetes Prow Robot 2022-08-23 22:33:49 -07:00 committed by GitHub
commit dabb1c5f93
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
cmd/kubeadm/app/util/version_test.go
View File

@ -50,6 +50,7 @@ func TestValidVersion(t *testing.T) {
"v1.5.0-alpha.0.1078+1044b6822497da-pull", "v1.5.0-alpha.0.1078+1044b6822497da-pull",
"v1.5.0-alpha.1.822+49b9e32fad9f32-pull-gke-gci", "v1.5.0-alpha.1.822+49b9e32fad9f32-pull-gke-gci",
"v1.6.1+coreos.0", "v1.6.1+coreos.0",
"1.7.1",
} }
for _, s := range validVersions { for _, s := range validVersions {
t.Run(s, func(t *testing.T) { t.Run(s, func(t *testing.T) {
@ -58,7 +59,7 @@ func TestValidVersion(t *testing.T) {
if err != nil { if err != nil {
t.Errorf("KubernetesReleaseVersion unexpected error for version %q: %v", s, err) t.Errorf("KubernetesReleaseVersion unexpected error for version %q: %v", s, err)
} }
if ver != s { if ver != s && ver != "v"+s {
t.Errorf("KubernetesReleaseVersion should return same valid version string. %q != %q", s, ver) t.Errorf("KubernetesReleaseVersion should return same valid version string. %q != %q", s, ver)
} }
}) })
@ -203,6 +204,9 @@ func TestSplitVersion(t *testing.T) {
{"unknown-1", "https://dl.k8s.io/release", "unknown-1", true}, {"unknown-1", "https://dl.k8s.io/release", "unknown-1", true},
// unknown area, not valid input. // unknown area, not valid input.
{"unknown/latest-1", "", "", false}, {"unknown/latest-1", "", "", false},
// invalid input
{"", "", "", false},
{"ci/", "", "", false},
} }
for _, tc := range cases { for _, tc := range cases {
@ -235,6 +239,7 @@ func TestKubernetesIsCIVersion(t *testing.T) {
// CI builds // CI builds
{"ci/latest-1", true}, {"ci/latest-1", true},
{"ci/v1.9.0-alpha.1.123+acbcbfd53bfa0a", true}, {"ci/v1.9.0-alpha.1.123+acbcbfd53bfa0a", true},
{"ci/", false},
} }
for _, tc := range cases { for _, tc := range cases {
@ -265,6 +270,7 @@ func TestCIBuildVersion(t *testing.T) {
{"ci/v1.9.0-alpha.1.123+acbcbfd53bfa0a", "v1.9.0-alpha.1.123+acbcbfd53bfa0a", true}, {"ci/v1.9.0-alpha.1.123+acbcbfd53bfa0a", "v1.9.0-alpha.1.123+acbcbfd53bfa0a", true},
{"ci/1.9.0-alpha.1.123+acbcbfd53bfa0a", "v1.9.0-alpha.1.123+acbcbfd53bfa0a", true}, {"ci/1.9.0-alpha.1.123+acbcbfd53bfa0a", "v1.9.0-alpha.1.123+acbcbfd53bfa0a", true},
{"ci/0invalid", "", false}, {"ci/0invalid", "", false},
{"0invalid", "", false},
} }
for _, tc := range cases { for _, tc := range cases {