github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-25 12:43:23 +00:00
Code Issues Projects Releases Wiki Activity

token cache: make fetch_total a counter

Browse Source 
Downstreams assume process restarts when counters decrement. Currently,
the "active" label is expected to decrement but the "ok" and "error"
labels are intended to be handled as counters. This is unneccesary and
hard to deal with. This changes consolidate "blocking" and "in_flight"
tracking into a single guage, which allows fetch completion to be a pure
counter.
This commit is contained in:
Mike Danese 2020-01-07 08:48:25 -08:00
parent ca70efd741
commit dc5934f584
1 changed files with 15 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
staging/src/k8s.io/apiserver/pkg/authentication/token/cache/stats.go vendored
View File

@ -42,8 +42,8 @@ var (
},
[]string{"status"},
)
fetchCount = metrics.NewGaugeVec(
&metrics.GaugeOpts{
fetchCount = metrics.NewCounterVec(
&metrics.CounterOpts{
Namespace: "authentication",
Subsystem: "token_cache",
Name: "fetch_total",
@ -51,13 +51,14 @@ var (
},
[]string{"status"},
)
blockCount = metrics.NewGauge(
activeFetchCount = metrics.NewGaugeVec(
&metrics.GaugeOpts{
Namespace: "authentication",
Subsystem: "token_cache",
Name: "block_count",
Name: "active_fetch_count",
StabilityLevel: metrics.ALPHA,
},
[]string{"status"},
)
)
@ -66,7 +67,7 @@ func init() {
requestLatency,
requestCount,
fetchCount,
blockCount,
activeFetchCount,
)
}
@ -74,9 +75,11 @@ const (
hitTag = "hit"
missTag = "miss"
fetchActiveTag = "active"
fetchFailedTag = "error"
fetchOkTag = "ok"
fetchInFlightTag = "in_flight"
fetchBlockedTag = "blocked"
)
type statsCollector struct{}
@ -101,12 +104,12 @@ func (statsCollector) authenticating() func(hit bool) {
}
func (statsCollector) blocking() func() {
blockCount.Inc()
return blockCount.Dec
activeFetchCount.WithLabelValues(fetchBlockedTag).Inc()
return activeFetchCount.WithLabelValues(fetchBlockedTag).Dec
}
func (statsCollector) fetching() func(ok bool) {
fetchCount.WithLabelValues(fetchActiveTag).Inc()
activeFetchCount.WithLabelValues(fetchInFlightTag).Inc()
return func(ok bool) {
var tag string
if ok {
@ -115,6 +118,8 @@ func (statsCollector) fetching() func(ok bool) {
tag = fetchFailedTag
}
fetchCount.WithLabelValues(tag).Dec()
fetchCount.WithLabelValues(tag).Inc()
activeFetchCount.WithLabelValues(fetchInFlightTag).Dec()
}
}