github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-06 18:54:06 +00:00
Code Issues Projects Releases Wiki Activity

e2e: node: podresources: cooldown the rate limit

Browse Source 
We have a e2e test which want to get a rate limit error. To do so, we
sent an abnormally high amount of calls in a tight loop.

The relevant test per se is reportedly fine, but wwe need to play nicer
with *other* tests which may run just after and which need to query the API.
If the testsuite runs "too fast", it's possible an innocent test falls in the
same rate limit watch period which was saturated by the ratelimit test,
so the innocent test can still be throttled because the throttling period
is not exhausted yet, yielding false negatives, leading to flakes.

We can't reset the period for the rate limit, we just wait "long enough" to
make sure we absorb the burst and other legit queries are not rejected.

Signed-off-by: Francesco Romani <fromani@redhat.com>
This commit is contained in:
Francesco Romani 2023-06-29 17:40:12 +02:00
parent 9516a25ce4
commit dfc150ca18
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
test/e2e_node/podresources_test.go
View File

@ -903,6 +903,14 @@ var _ = SIGDescribe("POD Resources [Serial] [Feature:PodResources][NodeFeature:P
gomega.Expect(errLimitExceededCount).ToNot(gomega.BeZero(), "never hit the rate limit trying %d calls in %v", tries, elapsed)
framework.Logf("got %d/%d rate limit errors, at least one needed, the more the better", errLimitExceededCount, tries)
// this is not needed for this test. We're done. But we need to play nice with *other* tests which may run just after,
// and which need to query the API. If they run "too fast", they can still be throttled because the throttling period
// is not exhausted yet, yielding false negatives, leading to flakes.
// We can't reset the period for the rate limit, we just wait "long enough" to make sure we absorb the burst
// and other queries are not rejected because happening to soon
ginkgo.By("Cooling down to reset the podresources API rate limit")
time.Sleep(5 * time.Second)
})
})
})