Merge pull request #3509 from enisoc/apiserver-proxy-trailing-slash

Preserve trailing slash in apiserver proxy.
This commit is contained in:
Nikhil Jindal 2015-01-15 15:13:49 -08:00
commit e6c5d59a55
2 changed files with 7 additions and 0 deletions

View File

@ -96,6 +96,12 @@ func (r *ProxyHandler) ServeHTTP(w http.ResponseWriter, req *http.Request) {
if len(parts) > 2 {
proxyParts := parts[2:]
rest = strings.Join(proxyParts, "/")
if strings.HasSuffix(req.URL.Path, "/") {
// The original path had a trailing slash, which has been stripped
// by KindAndNamespace(). We should add it back because some
// servers (like etcd) require it.
rest = rest + "/"
}
}
storage, ok := r.storage[kind]
if !ok {

View File

@ -174,6 +174,7 @@ func TestProxy(t *testing.T) {
{"PUT", "/some/dir/id", "different question", "answer", "text/css", "default"},
{"DELETE", "/some/dir/id", "", "ok", "text/css", "default"},
{"GET", "/some/dir/id", "", "answer", "text/css", "other"},
{"GET", "/trailing/slash/", "", "answer", "text/css", "default"},
}
for _, item := range table {