mirror of
https://github.com/k3s-io/kubernetes.git
synced 2025-07-24 12:15:52 +00:00
Merge pull request #58878 from liggitt/deprecated-feature
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Categorize deprecated feature gate more accurately related to #58761 follow up from https://github.com/kubernetes/kubernetes/pull/57265 to clarify the status of the feature gate ```release-note NONE ```
This commit is contained in:
commit
e8225f5618
@ -170,7 +170,7 @@ const (
|
||||
ServiceNodeExclusion utilfeature.Feature = "ServiceNodeExclusion"
|
||||
|
||||
// owner @brendandburns
|
||||
// stable: v1.10
|
||||
// deprecated: v1.10
|
||||
//
|
||||
// Enable the service proxy to contact external IP addresses. Note this feature is present
|
||||
// only for backward compatability, it will be removed in the 1.11 release.
|
||||
@ -284,6 +284,6 @@ var defaultKubernetesFeatureGates = map[utilfeature.Feature]utilfeature.FeatureS
|
||||
// unintentionally on either side:
|
||||
apiextensionsfeatures.CustomResourceValidation: {Default: true, PreRelease: utilfeature.Beta},
|
||||
|
||||
// backward compatability features that enable backwards compatability but should be removed soon.
|
||||
ServiceProxyAllowExternalIPs: {Default: false, PreRelease: utilfeature.Beta},
|
||||
// features that enable backwards compatability but are scheduled to be removed
|
||||
ServiceProxyAllowExternalIPs: {Default: false, PreRelease: utilfeature.Deprecated},
|
||||
}
|
||||
|
@ -67,6 +67,9 @@ const (
|
||||
Alpha = prerelease("ALPHA")
|
||||
Beta = prerelease("BETA")
|
||||
GA = prerelease("")
|
||||
|
||||
// Deprecated
|
||||
Deprecated = prerelease("DEPRECATED")
|
||||
)
|
||||
|
||||
// FeatureGate parses and stores flag gates for known features from
|
||||
@ -157,7 +160,7 @@ func (f *featureGate) Set(value string) error {
|
||||
}
|
||||
arr := strings.SplitN(s, "=", 2)
|
||||
k := Feature(strings.TrimSpace(arr[0]))
|
||||
_, ok := known[k]
|
||||
featureSpec, ok := known[k]
|
||||
if !ok {
|
||||
return fmt.Errorf("unrecognized key: %s", k)
|
||||
}
|
||||
@ -170,6 +173,9 @@ func (f *featureGate) Set(value string) error {
|
||||
return fmt.Errorf("invalid value of %s: %s, err: %v", k, v, err)
|
||||
}
|
||||
enabled[k] = boolValue
|
||||
if boolValue && featureSpec.PreRelease == Deprecated {
|
||||
glog.Warningf("enabling deprecated feature gate %s", k)
|
||||
}
|
||||
|
||||
// Handle "special" features like "all alpha gates"
|
||||
if fn, found := f.special[k]; found {
|
||||
|
Loading…
Reference in New Issue
Block a user