github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2026-07-18 13:57:38 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #131166 from siyuanfoundation/simple

Browse Source 
[Compatibility Version] suggestChangeEmulationVersion if setting locked feature.
This commit is contained in:
Kubernetes Prow Robot
2025-05-15 13:57:13 -07:00
committed by GitHub
parent 347c54da6e 90b256537c
commit ea1b40f8ce
1 changed files with 27 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
staging/src/k8s.io/component-base/featuregate/testing/feature_gate.go
View File

@@ -65,7 +65,11 @@ func SetFeatureGateDuringTest(tb TB, gate featuregate.FeatureGate, f featuregate
}
if err := gate.(featuregate.MutableFeatureGate).Set(fmt.Sprintf("%s=%v", f, value)); err != nil {
tb.Errorf("error setting %s=%v: %v", f, value, err)
if s := suggestChangeEmulationVersion(tb, gate, f, value); s != "" {
tb.Errorf("error setting %s=%v: %v. %s", f, value, err, s)
} else {
tb.Errorf("error setting %s=%v: %v", f, value, err)
}
}
tb.Cleanup(func() {
@@ -88,6 +92,28 @@ func SetFeatureGateDuringTest(tb TB, gate featuregate.FeatureGate, f featuregate
})
}
func suggestChangeEmulationVersion(tb TB, gate featuregate.FeatureGate, f featuregate.Feature, value bool) string {
mutableVersionedFeatureGate, ok := gate.(featuregate.MutableVersionedFeatureGate)
if !ok {
return ""
}
emuVer := mutableVersionedFeatureGate.EmulationVersion()
versionedSpecs, ok := mutableVersionedFeatureGate.GetAllVersioned()[f]
if !ok {
return ""
}
if len(versionedSpecs) > 1 {
// check if the feature is locked
lastLifecycle := versionedSpecs[len(versionedSpecs)-1]
if lastLifecycle.LockToDefault && !lastLifecycle.Version.GreaterThan(emuVer) && lastLifecycle.Default != value {
// if the feature is locked, set the emulation version to the previous version when the feature is not locked.
return fmt.Sprintf("Feature %s is locked at version %s. Try adding SetFeatureGateEmulationVersionDuringTest(t, gate, version.MustParse(\"1.%d\")) at the beginning of your test.", f, emuVer.String(), lastLifecycle.Version.SubtractMinor(1).Minor())
}
}
return ""
}
// SetFeatureGateEmulationVersionDuringTest sets the specified gate to the specified emulation version for duration of the test.
// Fails when it detects second call to set a different emulation version or is unable to set or restore emulation version.
// WARNING: Can leak set variable when called in test calling t.Parallel(), however second attempt to set a different emulation version will cause fatal.