github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-27 13:37:30 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #96229 from adtac/apfrace

Browse Source 
apiserver/filters test: fix data race and do not leak goroutines
This commit is contained in:
Kubernetes Prow Robot 2020-11-05 06:31:44 -08:00 committed by GitHub
commit ec1541c38f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
staging/src/k8s.io/apiserver/pkg/server/filters/priority-and-fairness_test.go
View File

@ -294,15 +294,17 @@ func TestApfExecuteMultipleRequests(t *testing.T) {
defer cancel() defer cancel()
StartPriorityAndFairnessWatermarkMaintenance(ctx.Done()) StartPriorityAndFairnessWatermarkMaintenance(ctx.Done())
var wg sync.WaitGroup
wg.Add(concurrentRequests)
for i := 0; i < concurrentRequests; i++ { for i := 0; i < concurrentRequests; i++ {
var err error
go func() { go func() {
err = expectHTTPGet(fmt.Sprintf("%s/api/v1/namespaces/default", server.URL), http.StatusOK) defer wg.Done()
}() if err := expectHTTPGet(fmt.Sprintf("%s/api/v1/namespaces/default", server.URL), http.StatusOK); err != nil {
if err != nil {
t.Error(err) t.Error(err)
} }
}()
} }
wg.Wait()
checkForExpectedMetricsWithRetry(t, []string{ checkForExpectedMetricsWithRetry(t, []string{
"apiserver_current_inflight_requests", "apiserver_current_inflight_requests",