github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-23 11:50:44 +00:00
Code Issues Projects Releases Wiki Activity

Deflake serving options, avoid hard-coding ports

Browse Source
This commit is contained in:
Jordan Liggitt 2020-09-04 15:55:01 -04:00
parent a23cf7077e
commit ec3faa1821
1 changed files with 13 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
staging/src/k8s.io/apiserver/pkg/server/options/serving_unix_test.go
View File

@ -19,31 +19,37 @@ limitations under the License.
package options
import (
"fmt"
"net"
"testing"
)
func TestCreateListenerSharePort(t *testing.T) {
addr := "127.0.0.1:12345"
c := net.ListenConfig{Control: permitPortReuse}
if _, _, err := CreateListener("tcp", addr, c); err != nil {
l, port, err := CreateListener("tcp", "127.0.0.1:0", c)
if err != nil {
t.Fatalf("failed to create listener: %v", err)
}
defer l.Close()
if _, _, err := CreateListener("tcp", addr, c); err != nil {
l2, _, err := CreateListener("tcp", fmt.Sprintf("127.0.0.1:%d", port), c)
if err != nil {
t.Fatalf("failed to create 2nd listener: %v", err)
}
defer l2.Close()
}
func TestCreateListenerPreventUpgrades(t *testing.T) {
addr := "127.0.0.1:12346"
if _, _, err := CreateListener("tcp", addr, net.ListenConfig{}); err != nil {
l, port, err := CreateListener("tcp", "127.0.0.1:0", net.ListenConfig{})
if err != nil {
t.Fatalf("failed to create listener: %v", err)
}
defer l.Close()
if _, _, err := CreateListener("tcp", addr, net.ListenConfig{Control: permitPortReuse}); err == nil {
l2, _, err := CreateListener("tcp", fmt.Sprintf("127.0.0.1:%d", port), net.ListenConfig{Control: permitPortReuse})
if err == nil {
l2.Close()
t.Fatalf("creating second listener without port sharing should fail")
}
}