cleancode: graph_builder.go

This commit is contained in:
zhangxiaoyu-zidif 2017-04-21 11:12:54 +08:00
parent 3153cd6841
commit f1df40d5ee

View File

@ -285,13 +285,13 @@ type ownerRefPair struct {
// when the number of references is small. // when the number of references is small.
func referencesDiffs(old []metav1.OwnerReference, new []metav1.OwnerReference) (added []metav1.OwnerReference, removed []metav1.OwnerReference, changed []ownerRefPair) { func referencesDiffs(old []metav1.OwnerReference, new []metav1.OwnerReference) (added []metav1.OwnerReference, removed []metav1.OwnerReference, changed []ownerRefPair) {
oldUIDToRef := make(map[string]metav1.OwnerReference) oldUIDToRef := make(map[string]metav1.OwnerReference)
for i := 0; i < len(old); i++ { for _, value := range old {
oldUIDToRef[string(old[i].UID)] = old[i] oldUIDToRef[string(value.UID)] = value
} }
oldUIDSet := sets.StringKeySet(oldUIDToRef) oldUIDSet := sets.StringKeySet(oldUIDToRef)
newUIDToRef := make(map[string]metav1.OwnerReference) newUIDToRef := make(map[string]metav1.OwnerReference)
for i := 0; i < len(new); i++ { for _, value := range new {
newUIDToRef[string(new[i].UID)] = new[i] newUIDToRef[string(value.UID)] = value
} }
newUIDSet := sets.StringKeySet(newUIDToRef) newUIDSet := sets.StringKeySet(newUIDToRef)