github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-31 07:20:13 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #37558 from jayunit100/scheduler_log_spam

Browse Source 
Automatic merge from submit-queue (batch tested with PRs 38076, 38137, 36882, 37634, 37558)

[scheduler] Use V(10) for anything which may be O(N*P) logging

Fixes #37014

This PR makes sure that logging statements which are capable of being called on a perNode / perPod basis (i.e. non essential ones that will just clog up logs at large scale) are at V(10) level.

I dreamt of a levenstein filter that built a weak map of word frequencies and alerted once log throughput increased w/o varying information content....  but then I woke up and realized this is probably all we really need for now :)
This commit is contained in:
Kubernetes Submit Queue 2016-12-05 19:25:57 -08:00 committed by GitHub
commit f299a0010a
4 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
plugin/pkg/scheduler/algorithm/predicates/metadata.go
View File

@ -52,7 +52,7 @@ func (pfactory *PredicateMetadataFactory) GetMetadata(pod *v1.Pod, nodeNameToInf
matchingAntiAffinityTerms: matchingTerms,
}
for predicateName, precomputeFunc := range predicatePrecomputations {
glog.V(4).Info("Precompute: %v", predicateName)
glog.V(10).Info("Precompute: %v", predicateName)
precomputeFunc(predicateMetadata)
}
return predicateMetadata

2
plugin/pkg/scheduler/algorithm/predicates/predicates.go
View File

@ -417,7 +417,7 @@ func (c *VolumeZoneChecker) predicate(pod *v1.Pod, meta interface{}, nodeInfo *s
}
nodeV, _ := nodeConstraints[k]
if v != nodeV {
glog.V(2).Infof("Won't schedule pod %q onto node %q due to volume %q (mismatch on %q)", pod.Name, node.Name, pvName, k)
glog.V(10).Infof("Won't schedule pod %q onto node %q due to volume %q (mismatch on %q)", pod.Name, node.Name, pvName, k)
return false, []algorithm.PredicateFailureReason{ErrVolumeZoneConflict}, nil
}
}

2
plugin/pkg/scheduler/algorithm/priorities/least_requested.go
View File

@ -49,7 +49,7 @@ func calculateUnusedScore(requested int64, capacity int64, node string) int64 {
return 0
}
if requested > capacity {
glog.V(4).Infof("Combined requested resources %d from existing pods exceeds capacity %d on node %s",
glog.V(10).Infof("Combined requested resources %d from existing pods exceeds capacity %d on node %s",
requested, capacity, node)
return 0
}

2
plugin/pkg/scheduler/algorithm/priorities/most_requested.go
View File

@ -53,7 +53,7 @@ func calculateUsedScore(requested int64, capacity int64, node string) int64 {
return 0
}
if requested > capacity {
glog.V(4).Infof("Combined requested resources %d from existing pods exceeds capacity %d on node %s",
glog.V(10).Infof("Combined requested resources %d from existing pods exceeds capacity %d on node %s",
requested, capacity, node)
return 0
}