github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2026-07-18 04:54:54 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #134277 from lalitc375/devex

Browse Source 
Improve developer experience for DV tests
This commit is contained in:
Kubernetes Prow Robot
2025-09-25 21:12:16 -07:00
committed by GitHub
parent 9a3dce00ae 3015e58e40
commit f884da7ff9
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
pkg/api/testing/validation.go
View File

@@ -222,7 +222,7 @@ func verifyValidationEquivalence(t *testing.T, expectedErrs field.ErrorList, run
}
})
t.Run("without declarative validation", func(t *testing.T) {
t.Run("hand written validation", func(t *testing.T) {
featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.DeclarativeValidationTakeover, false)
featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.DeclarativeValidation, false)
imperativeErrs = runValidations()
@@ -234,6 +234,11 @@ func verifyValidationEquivalence(t *testing.T, expectedErrs field.ErrorList, run
}
})
if t.Failed() {
// There is no point in moving forward, if any of above tests failed for any reason. Running follow up tests will return noise.
t.SkipNow()
}
// The equivalenceMatcher is used to verify the output errors from hand-written imperative validation
// are equivalent to the output errors when DeclarativeValidationTakeover is enabled.
equivalenceMatcher := field.ErrorMatcher{}.ByType().ByField().ByOrigin()