github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2026-07-18 04:54:54 +00:00
Code Issues Projects Releases Wiki Activity

refactor: skip re-validating for unchanged resource claim specs

Browse Source
This commit is contained in:
yongruilin
2025-09-16 17:33:44 +00:00
parent 8826364a57
commit f8d2df0f74
1 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
pkg/apis/resource/validation/validation.go
View File

@@ -95,11 +95,10 @@ func ValidateResourceClaim(resourceClaim *resource.ResourceClaim) field.ErrorLis
// ValidateResourceClaimUpdate tests if an update to ResourceClaim is valid.
func ValidateResourceClaimUpdate(resourceClaim, oldClaim *resource.ResourceClaim) field.ErrorList {
allErrs := corevalidation.ValidateObjectMetaUpdate(&resourceClaim.ObjectMeta, &oldClaim.ObjectMeta, field.NewPath("metadata"))
// The spec is immutable. On update, we only check for immutability.
// Re-validating other fields is skipped because the user cannot change them;
// the only actionable error is for the immutability violation.
allErrs = append(allErrs, apimachineryvalidation.ValidateImmutableField(resourceClaim.Spec, oldClaim.Spec, field.NewPath("spec"))...)
// Because the spec is immutable, all CEL expressions in it must have been stored.
// If the user tries an update, this is not true and checking is less strict, but
// as there are errors, it doesn't matter.
allErrs = append(allErrs, validateResourceClaimSpec(&resourceClaim.Spec, field.NewPath("spec"), true)...)
return allErrs
}
@@ -580,11 +579,10 @@ func validateResourceClaimTemplateSpec(spec *resource.ResourceClaimTemplateSpec,
// ValidateResourceClaimTemplateUpdate tests if an update to template is valid.
func ValidateResourceClaimTemplateUpdate(template, oldTemplate *resource.ResourceClaimTemplate) field.ErrorList {
allErrs := corevalidation.ValidateObjectMetaUpdate(&template.ObjectMeta, &oldTemplate.ObjectMeta, field.NewPath("metadata"))
// The spec is immutable. On update, we only check for immutability.
// Re-validating other fields is skipped because the user cannot change them;
// the only actionable error is for the immutability violation.
allErrs = append(allErrs, apimachineryvalidation.ValidateImmutableField(template.Spec, oldTemplate.Spec, field.NewPath("spec"))...)
// Because the spec is immutable, all CEL expressions in it must have been stored.
// If the user tries an update, this is not true and checking is less strict, but
// as there are errors, it doesn't matter.
allErrs = append(allErrs, validateResourceClaimTemplateSpec(&template.Spec, field.NewPath("spec"), true)...)
return allErrs
}