github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-23 11:50:44 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #39628 from deads2k/fix-throttle

Browse Source 
Automatic merge from submit-queue (batch tested with PRs 39628, 39551, 38746, 38352, 39607)

fix throttling test

Fixes https://github.com/kubernetes/kubernetes/issues/39285.

The token bucket starts full, so getting 100 tokens doesn't take a full second, right?  Getting 101 tokens does take a full second.

@liggitt looks like your test.
This commit is contained in:
Kubernetes Submit Queue 2017-01-10 11:54:12 -08:00 committed by GitHub
commit fb256b2911
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
pkg/util/flowcontrol/throttle_test.go
View File

@ -64,7 +64,8 @@ func TestMultithreadedThrottling(t *testing.T) {
// record wall time
endTime := time.Now()
if duration := endTime.Sub(startTime); duration < time.Second {
// tolerate a 1% clock change because these things happen
if duration := endTime.Sub(startTime); duration < (time.Second * 99 / 100) {
// We shouldn't be able to get 100 tokens out of the bucket in less than 1 second of wall clock time, no matter what
t.Errorf("Expected it to take at least 1 second to get 100 tokens, took %v", duration)
} else {