github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-04 18:00:08 +00:00
Code Issues Projects Releases Wiki Activity

Use DeleteDropWatch instead of Delete in test

Browse Source 
Using the latter resulted in receiving extra OnDelete event callbacks. Using
DeleteDropWatch removed the flake.

Fixes #14138.
This commit is contained in:
Daniel Martí 2015-09-26 11:52:44 -07:00
parent 61e4eb4e1f
commit fdd7322b38
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/controller/framework/controller_test.go
View File

@ -133,7 +133,7 @@ func ExampleInformer() {
time.Millisecond*100, time.Millisecond*100,
framework.ResourceEventHandlerFuncs{ framework.ResourceEventHandlerFuncs{
AddFunc: func(obj interface{}) { AddFunc: func(obj interface{}) {
source.Delete(obj.(runtime.Object)) source.DeleteDropWatch(obj.(runtime.Object))
}, },
DeleteFunc: func(obj interface{}) { DeleteFunc: func(obj interface{}) {
key, err := framework.DeletionHandlingMetaNamespaceKeyFunc(obj) key, err := framework.DeletionHandlingMetaNamespaceKeyFunc(obj)
@ -327,7 +327,7 @@ func TestUpdate(t *testing.T) {
if !allowedTransitions[pair{from, to}] { if !allowedTransitions[pair{from, to}] {
t.Errorf("observed transition %q -> %q for %v", from, to, n.Name) t.Errorf("observed transition %q -> %q for %v", from, to, n.Name)
} }
source.Delete(n) source.DeleteDropWatch(n)
}, },
DeleteFunc: func(obj interface{}) { DeleteFunc: func(obj interface{}) {
testDoneWG.Done() testDoneWG.Done()