Address review comments

Change type name and stuff

pkg/scheduler/framework/plugins/nodevolumelimits/csi_manager.go

@@ -24,18 +24,18 @@ import (
 )
 
 // CSIManagerImpl is a implementation of the CSIManager interface.
-type CSIManagerImpl struct {
-	csiNodeListerImpl *csiNodeLister
+type DefaultCSIManager struct {
+	defaultCSINodeLister *csiNodeLister
 }
 
-var _ fwk.CSIManager = &CSIManagerImpl{}
+var _ fwk.CSIManager = &DefaultCSIManager{}
 
-func NewCSIManager(csinodeLister storagelisters.CSINodeLister) *CSIManagerImpl {
-	return &CSIManagerImpl{csiNodeListerImpl: NewCsiNodeLister(csinodeLister)}
+func NewCSIManager(csinodeLister storagelisters.CSINodeLister) *DefaultCSIManager {
+	return &DefaultCSIManager{defaultCSINodeLister: NewCsiNodeLister(csinodeLister)}
 }
 
-func (m *CSIManagerImpl) CSINodes() fwk.CSINodeLister {
-	return m.csiNodeListerImpl
+func (m *DefaultCSIManager) CSINodes() fwk.CSINodeLister {
+	return m.defaultCSINodeLister
 }
 
 type csiNodeLister struct {

pkg/scheduler/framework/runtime/framework.go

@@ -54,22 +54,21 @@ const (
 type frameworkImpl struct {
 	registry             Registry
 	snapshotSharedLister fwk.SharedLister
-
-	waitingPods       *waitingPodsMap
-	scorePluginWeight map[string]int
-	preEnqueuePlugins []fwk.PreEnqueuePlugin
-	enqueueExtensions []fwk.EnqueueExtensions
-	queueSortPlugins  []fwk.QueueSortPlugin
-	preFilterPlugins  []fwk.PreFilterPlugin
-	filterPlugins     []fwk.FilterPlugin
-	postFilterPlugins []fwk.PostFilterPlugin
-	preScorePlugins   []fwk.PreScorePlugin
-	scorePlugins      []fwk.ScorePlugin
-	reservePlugins    []fwk.ReservePlugin
-	preBindPlugins    []fwk.PreBindPlugin
-	bindPlugins       []fwk.BindPlugin
-	postBindPlugins   []fwk.PostBindPlugin
-	permitPlugins     []fwk.PermitPlugin
+	waitingPods          *waitingPodsMap
+	scorePluginWeight    map[string]int
+	preEnqueuePlugins    []fwk.PreEnqueuePlugin
+	enqueueExtensions    []fwk.EnqueueExtensions
+	queueSortPlugins     []fwk.QueueSortPlugin
+	preFilterPlugins     []fwk.PreFilterPlugin
+	filterPlugins        []fwk.FilterPlugin
+	postFilterPlugins    []fwk.PostFilterPlugin
+	preScorePlugins      []fwk.PreScorePlugin
+	scorePlugins         []fwk.ScorePlugin
+	reservePlugins       []fwk.ReservePlugin
+	preBindPlugins       []fwk.PreBindPlugin
+	bindPlugins          []fwk.BindPlugin
+	postBindPlugins      []fwk.PostBindPlugin
+	permitPlugins        []fwk.PermitPlugin
 
 	// pluginsMap contains all plugins, by name.
 	pluginsMap map[string]fwk.Plugin

pkg/scheduler/scheduler.go

@@ -344,8 +344,7 @@ func New(ctx context.Context,
 		}
 		draManager = dynamicresources.NewDRAManager(ctx, resourceClaimCache, resourceSliceTracker, informerFactory)
 	}
-	var sharedCSIManager fwk.CSIManager
-	sharedCSIManager = nodevolumelimits.NewCSIManager(informerFactory.Storage().V1().CSINodes().Lister())
+	sharedCSIManager := nodevolumelimits.NewCSIManager(informerFactory.Storage().V1().CSINodes().Lister())
 
 	var apiDispatcher *apidispatcher.APIDispatcher
 	if feature.DefaultFeatureGate.Enabled(features.SchedulerAsyncAPICalls) {