github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-21 10:51:29 +00:00
Code Issues Projects Releases Wiki Activity

Improve storage test skipping pattern.

Browse Source 
Including a skip method as the first line of a test does not prevent the test to fail in the BeforeEach function.
If the test is skipped because of a tag in the name, then we can prevent such odd behavior.
This commit is contained in:
Juan Escobar 2021-07-22 21:42:30 -05:00
parent 4818e5844e
commit fef5c0c1a6
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/e2e/storage/persistent_volumes-local.go
View File

@ -283,8 +283,8 @@ var _ = utils.SIGDescribe("PersistentVolumes-local ", func() {
e2epod.DeletePodOrFail(config.client, config.ns, pod2.Name)
})
ginkgo.It("should set different fsGroup for second pod if first pod is deleted", func() {
e2eskipper.Skipf("Disabled temporarily, reopen after #73168 is fixed")
ginkgo.It("should set different fsGroup for second pod if first pod is deleted [Flaky]", func() {
// TODO: Disabled temporarily, remove [Flaky] tag after #73168 is fixed.
fsGroup1, fsGroup2 := int64(1234), int64(4321)
ginkgo.By("Create first pod and check fsGroup is set")
pod1 := createPodWithFsGroupTest(config, testVol, fsGroup1, fsGroup1)