Commit Graph

82 Commits

Author SHA1 Message Date
Jan Safranek
a53c6f1dc8 Add validation of CSIDriver.SELinuxMount 2023-03-14 16:49:55 +01:00
TommyStarK
c242e647ae pkg/apis: Replace deprecated pointer function
Signed-off-by: TommyStarK <thomasmilox@gmail.com>
2023-01-08 13:14:37 +01:00
Manjusaka
0843c4dfca
Add extra value validation for matchExpression field in LabelSelector 2022-11-07 20:48:21 -05:00
Jiawei Wang
760365d5c9 CSIMigration feature gate to GA 2022-06-06 21:19:19 +00:00
Patrick Ohly
3a7deaa141 storage capacity: GA, always enabled, remove feature check
The code and tests for scenarios where the feature is disabled are no longer
needed because the feature is graduating to GA.
2022-03-14 20:05:45 +01:00
Patrick Ohly
dfaeacb51f CSIDriver: allow "StorageCapacity" to be modified
When originally introduced, the field was made immutable to be
consistent with the other fields. But in practice allowing it to be
toggled makes more sense, in particular when considering the rollout
of a CSI driver (let it run without using the published
CSIStorageCapacity object, then flip the field, or upgrading from a
driver without support to one which supports it).

The only consumer of this field, the kube-scheduler, can handle
mutation without problems because it always consults the informer
cache to get the current value.
2021-08-11 15:10:30 +02:00
Davanum Srinivas
75748c185e
enable verify-golangci-lint.sh
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2021-07-14 08:53:33 -04:00
Davanum Srinivas
07332ad398
fix ineffassign and varcheck
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2021-07-14 08:41:22 -04:00
Chris Henzie
9ba0eed7c5 Add validation options for PersistentVolumes
These options provide an extensible way of configuring how PVs are
validated
2021-06-28 21:24:55 -07:00
Kubernetes Prow Robot
7b24c7e4a7
Merge pull request #101256 from Jiawei0227/length2
Relax csiNodeIDMaxLength length limit to 256
2021-06-23 02:10:10 -07:00
CKchen0726
918246d7a1 update error info with the new limit in #98753 2021-06-03 11:08:09 +08:00
creydr
f38615fb9d Change the users of IsQualifiedName to ValidateQualifiedName 2021-05-18 10:49:15 +02:00
Jiawei Wang
125fb04dbf Relax node_id length limit to 256 2021-04-19 12:55:19 -07:00
Shihang Zhang
4ad1c71174 graduate CSIServiceAccountToken to beta 2021-03-09 18:36:35 -08:00
Kubernetes Prow Robot
dc74b9d0c7
Merge pull request #98753 from Jiawei0227/length
Relax csiNodeIDMaxLength to longer limit
2021-03-09 09:19:00 -08:00
Jiawei Wang
1e16615fb0 Relax csiNodeIDMaxLength to longer limit
Update csiNodeIDMaxLength to 192 bytes
2021-03-08 13:52:43 -08:00
Patrick Ohly
504f105a9e CSIStorageCapacity: prepare tests for enabling the feature by default
Defaults and validation are such that the field has to be set when
the feature is enabled, just as for the other boolean fields. This
was missing in some tests, which was okay as long as they ran
with the feature disabled. Once it gets enabled, validation will
flag the missing field as error.

Other tests didn't run at all.
2021-03-08 20:52:50 +01:00
Benjamin Elder
56e092e382 hack/update-bazel.sh 2021-02-28 15:17:29 -08:00
Christian Huffman
701b42ca2b Corrected CSIDriver validation rebase issues 2020-11-12 16:45:26 -05:00
Christian Huffman
8444823bed Remove duplicate CSIDriver name validation 2020-11-12 16:32:36 -05:00
Christian Huffman
3287dbf914 Adjust CSIDriver validation to check objectmeta 2020-11-12 16:30:40 -05:00
Christian Huffman
01f70d69b7 Move CSIVolumeFSGroupPolicy to beta 2020-11-12 16:28:54 -05:00
Christian Huffman
6b9348e878 Relax validation for CSIVolumeFSGroupPolicy 2020-11-12 16:26:20 -05:00
Shihang Zhang
d2859cd89b plumb service account token down to csi driver 2020-11-12 09:26:43 -08:00
Christian Huffman
e65f0f565a Updated dependencies 2020-07-11 23:29:24 -04:00
Christian Huffman
58bd3e5230 Include CSIDriver SupportsFsGroup 2020-07-11 23:29:24 -04:00
Patrick Ohly
9a66e8e1b5 CSIStorageCapacity: 'make update' 2020-07-03 21:54:14 +02:00
Patrick Ohly
1089954fa6 CSIStorageCapacity: CSIDriver.Spec.StorageCapacity field
This is needed to inform the Kubernetes pod scheduler whether it has
to check CSIStorageCapacity objects for available capacity.
2020-07-03 21:54:14 +02:00
Patrick Ohly
22aeb81e84 CSIStorageCapacity: CSIStorageCapacity API
This adds the CSIStorageCapacity API change for
https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/1472-storage-capacity-tracking
2020-07-03 21:54:14 +02:00
Kubernetes Prow Robot
b1b1fc8034
Merge pull request #81961 from pohly/ephemeral-unit-tests
storage: enhance test for ValidateCSIDriverUpdate
2020-07-01 07:10:34 -07:00
hwdef
6c6fd9c575 pkg/apis: fix staticcheck warning 2019-11-08 14:49:39 +08:00
Patrick Ohly
c20721aa9f storage: enhance test for ValidateCSIDriverUpdate
This revised test changes one field at a time in various ways. This
ensures that one failure reason doesn't mask the other.

An incorrect comment also gets fixed.

Suggested in https://github.com/kubernetes/kubernetes/pull/80568#pullrequestreview-272836101.
2019-08-26 21:45:39 +02:00
Patrick Ohly
1db1263476 storage: add test for ValidateCSIDriverUpdate
Adding this test was forgotten when adding CSIDriver.
2019-08-13 23:12:52 +02:00
Patrick Ohly
b60f08e24b storage: validate CSIDriver.Spec.VolumeLifecycleModes
This ensures that users get a good error message early on when trying
to do something that isn't okay:

  $ kubectl create -f csi-hostpath-driverinfo.yaml
  The CSIDriver "hostpath.csi.k8s.io" is invalid: spec.volumeLifecycleModes: Unsupported value: "foobar": supported values: "persistent", "ephemeral"
2019-08-13 23:12:48 +02:00
Ted Yu
bb77aa7a63 Validate CSI Inline Migration unconditionally 2019-08-06 08:33:31 -07:00
Fabio Bertinatto
b90ca5b2a7 Auto-generated code for volume limits API 2019-06-25 16:30:54 +02:00
Fabio Bertinatto
13e30b6342 Add volume limits API changes 2019-06-25 16:30:54 +02:00
Deep Debroy
df196226c4 Generated code for API changes to support CSI migration of inline volumes
Signed-off-by: Deep Debroy <ddebroy@docker.com>
2019-05-30 09:34:53 +00:00
Deep Debroy
c34309acdf API changes to support CSI migration of inline volumes
Signed-off-by: Deep Debroy <ddebroy@docker.com>
2019-05-30 09:34:47 +00:00
Àbéjídé Àyodélé
25df4e69a5 Clean up pkg/apis.
These are based on recommendation from
[staticcheck](http://staticcheck.io/).
2019-05-09 15:25:41 +00:00
Xing Yang
ba4ccfa8b1 Add review comments in the APIs 2019-03-02 18:40:22 -08:00
Xing Yang
bb45b8ee34 Make CSINodeInfo and CSIDriver Core APIs
This PR is the first step to transition CSINodeInfo and CSIDriver
CRD's to in-tree APIs. It adds them to the existing API group
“storage.k8s.io” as core storage APIs.
2019-03-02 12:31:05 -08:00
Jordan Liggitt
73dcfe12da Stop checking VolumeScheduling feature gate 2018-12-27 17:45:45 -05:00
Serguei Bezverkhi
082f23ab1b AllowVolumeExpansion validation and tests
Signed-off-by: Serguei Bezverkhi <sbezverk@cisco.com>
2018-12-20 17:04:47 -05:00
Jordan Liggitt
2498ca7606 drop VerifyFeatureGatesUnchanged 2018-11-21 11:51:33 -05:00
Jordan Liggitt
248d661327 Add tests to ensure storage feature gate changes don't escape packages 2018-11-16 10:52:53 -05:00
Jordan Liggitt
358c092abe fix storage unit tests leaking feature flag changes 2018-11-16 10:52:52 -05:00
Michelle Au
fd64c08240 Fix storage feature gate test setting 2018-11-16 10:49:40 -05:00
Jan Safranek
8cfce0af99 Tighten up validation of VolumeAttachment fields 2018-11-14 16:46:59 +01:00
Michelle Au
498cd61f41 Add volumeattachment status subresource 2018-11-14 14:01:16 +01:00