Commit Graph

2974 Commits

Author SHA1 Message Date
Wei Huang
0b27f25252
PreEnqueue implementation
- Add PreEnqueuePlugin to Scheduler Framework
- Implement PreEnqueuePlugin in scheduler queue
- Implementation of SchedulingGates plugin
- Metrics
2022-11-07 14:02:58 -08:00
Wei Huang
2de75d92bf
API, Codegen, UT for PreEnqueue extension point 2022-11-07 14:02:57 -08:00
Kubernetes Prow Robot
f33209a6ed
Merge pull request #111545 from jlsong01/rewrite_signature_of_StartEventWatcher
rewrite signature of function StartEventWatcher
2022-11-07 08:06:18 -08:00
Kubernetes Prow Robot
fce1fbec29
Merge pull request #113528 from iyear/remove-useless-set
scheduler/framework: remove useless SetFailedPlugin
2022-11-07 06:52:16 -08:00
Kubernetes Prow Robot
1d2e804287
Merge pull request #113505 from Abirdcfly/fixcomment
chore(scheduler): cleanup some minor issues in testing
2022-11-02 21:40:19 -07:00
Abirdcfly
bf8570029e
chore(scheduler): cleanup some minor issues in testing 2022-11-03 09:07:28 +08:00
Kubernetes Prow Robot
447706238f
Merge pull request #113419 from chrishenzie/rwop-integration-test
scheduler: integration test for ReadWriteOncePod alpha
2022-11-02 08:35:38 -07:00
iyear
a62f0c3b9f scheduler/framework: remove useless SetFailedPlugin
Signed-off-by: iyear <ljyngup@gmail.com>
2022-11-02 10:42:52 +08:00
Chris Henzie
2d0afbc054 scheduler: integration test for ReadWriteOncePod alpha
Tests scheduler enforcement of the ReadWriteOncePod PVC access mode.

- Creates a pod using a PVC with ReadWriteOncePod
- Creates a second pod using the same PVC
- Observes the second pod fails to schedule because PVC is in-use
- Deletes the first pod
- Observes the second pod successfully schedules
2022-11-01 15:08:01 -07:00
Kubernetes Prow Robot
4c657e5014
Merge pull request #110403 from claudiubelu/unittests-3
unittests: Fixes unit tests for Windows (part 3)
2022-10-31 15:52:44 -07:00
Michal Wozniak
fea883687f SSA to add pod failure conditions - ready for review 2022-10-27 18:21:33 +02:00
Yuan Chen
18f5b5c8e0 Replace deprecated pointer conversions in scheduler 2022-10-21 10:43:24 -07:00
Claudiu Belu
9f95b7b18c unittests: Fixes unit tests for Windows (part 3)
Currently, there are some unit tests that are failing on Windows due to
various reasons:

- paths not properly joined (filepath.Join should be used).
- Proxy Mode IPVS not supported on Windows.
- DeadlineExceeded can occur when trying to read data from an UDP
  socket. This can be used to detect whether the port was closed or not.
- In Windows, with long file name support enabled, file names can have
  up to 32,767 characters. In this case, the error
  windows.ERROR_FILENAME_EXCED_RANGE will be encountered instead.
- files not closed, which means that they cannot be removed / renamed.
- time.Now() is not as precise on Windows, which means that 2
  consecutive calls may return the same timestamp.
- path.Base() will return the same path. filepath.Base() should be used
  instead.
- path.Join() will always join the paths with a / instead of the OS
  specific separator. filepath.Join() should be used instead.
2022-10-21 19:25:48 +03:00
Kubernetes Prow Robot
18b81513b6
Merge pull request #112025 from kerthcet/refactor/handle-scheduling-failure
Refactor schedulingCycle and bindingCycle in scheduler
2022-10-21 08:31:51 -07:00
kerthcet
f7f857814f Refactor schedulingCycle and bindingCycle in scheduler
Signed-off-by: kerthcet <kerthcet@gmail.com>
2022-10-21 13:53:18 +08:00
Kubernetes Prow Robot
8305358630
Merge pull request #108494 from sanposhiho/RunScorePlugins-return-type
change framework.RunScorePlugins to return slice organized by node
2022-10-20 08:57:02 -07:00
sanposhiho
cbf1ea5e68 change framework.RunScorePlugins to return slice organized by node 2022-10-20 01:04:38 +00:00
Kubernetes Prow Robot
453039f47b
Merge pull request #113153 from yuanchen8911/error
Replace error string with ErrorList in scheduler validation testing
2022-10-19 16:34:56 -07:00
Yuan Chen
dd1b4fa407 Replace error string with ErrorList in scheduler valiation test
Remove expected status

Remove unnecessary code

Revert changes to BindVerb
2022-10-19 12:14:57 -07:00
Kubernetes Prow Robot
ca17d9ba2b
Merge pull request #113127 from tangwz/parallel_preemption
Do pod preemption in parallel.
2022-10-19 07:23:01 -07:00
tangwz
480ae2a7c1 Do pod preemption in parallel. 2022-10-19 09:28:53 +08:00
Kubernetes Prow Robot
424a98ccc2
Merge pull request #109662 from astraw99/fix-prebind-pvc-update
Replace `DeepEqual` to `Diff` compare on scheduler-binding
2022-10-18 11:29:18 -07:00
Kubernetes Prow Robot
2b6abb1b33
Merge pull request #113113 from kerthcet/fix/metics-in-scheduler
Fix metrics time durations in schedulerCycle and bindingCycle
2022-10-17 19:53:17 -07:00
Kubernetes Prow Robot
521fbd7e6a
Merge pull request #112521 from yuanchen8911/profile-config
Add a scheduler profile level parameter percentageOfNodesToScore
2022-10-17 11:09:06 -07:00
kerthcet
1582c42e2b Fix metrics time durations in schedulerCycle and bindingCycle
Signed-off-by: kerthcet <kerthcet@gmail.com>
2022-10-17 23:24:24 +08:00
SataQiu
ba925a8393 scheduler: remove unused constant DefaultBindTimeoutSeconds from VolumeBinding plugin 2022-10-17 17:25:59 +08:00
Yuan Chen
7297f48f12 Add profile level percentageOfNodesToScore
Fix conversion errors

Changed the order

update

update

fix manaul coversions

keep the global parameter for backward compatibility

Address Wei's comments

Fix an error

Fix issues

Add unit tests for validation

Fix a comment

Address comments

Update comments

fix verifiation errors

Add tests for scheme_test.go

Convert percentageOfNodesToScore to pointer

Fix errors

Resolve conflicts

Fix testing errors

Address Wei's comments

Revert IntPtr to Int changes

Address comments

Not overrite percentageOfNodesToScore

Fix a bug

Fix a bug

change errs to err

Fix a nit

Remove duplication

Address comments

Fix lint warning

Fix an issue

Update comments

Clean up

Address comments

Revert changes to defaults

fix unit test error

Update

Fix tests

Use default PluginConfigs
2022-10-14 13:01:06 -07:00
Kubernetes Prow Robot
040d7aaafa
Merge pull request #112939 from lengrongfu/feat/update_preemption_victims_metric
feat: update preemption victims metric
2022-10-13 16:38:46 -07:00
lengrongfu
8dcd869665 feat: update preemption victims metric
Signed-off-by: lengrongfu <rongfu.leng@daocloud.io>
2022-10-14 02:45:21 +08:00
kidddddddddddddddddddddd
b901ef0f68 changes in test files 2022-10-12 22:11:04 +08:00
kidddddddddddddddddddddd
121d24cfc7 changes in non-test files 2022-10-12 21:09:55 +08:00
kidddddddddddddddddddddd
1eb9d42c3f function changes 2022-10-12 21:00:48 +08:00
jlsong01
c8291e393b rewrite signature of function StartEventWatcher 2022-10-12 20:15:52 +08:00
Kubernetes Prow Robot
5113b705d2
Merge pull request #112563 from kerthcet/cleanup/optimize-new-scheduler
Remove newScheduler for reducing complexity
2022-10-11 12:32:41 -07:00
kerthcet
127178661d Remove newScheduler to simplify instantiation
Signed-off-by: kerthcet <kerthcet@gmail.com>
2022-10-10 10:25:37 +08:00
Kubernetes Prow Robot
27344212ce
Merge pull request #112827 from SataQiu/clean-scheduler-20221003
scheduler: cleanup the unused event types about Service
2022-10-04 16:24:00 -07:00
Kubernetes Prow Robot
6ece379ad6
Merge pull request #112658 from BinacsLee/binacs/cleanup-reuse-code-logic-in-nodeinfo
cleanup: reuse code logic in NodeInfo.AddPod & NodeInfo.RemovePod
2022-10-03 08:46:14 -07:00
BinacsLee
b616d41c25 cleanup: reuse code logic in NodeInfo.AddPod & NodeInfo.RemovePod 2022-10-03 21:10:50 +08:00
SataQiu
8640d17760 scheduler: cleanup the unused event types about Service 2022-10-03 16:30:38 +08:00
kerthcet
55dcde737d typo fixed
Signed-off-by: kerthcet <kerthcet@gmail.com>
2022-09-29 18:08:15 +08:00
SataQiu
7ab0c56f71 scheduler: remove unused plugin name ServiceAffinity 2022-09-28 17:25:18 +08:00
Monis Khan
f01295067f
Revert "Enable paralellism in scheduler unit tests"
This reverts commit f37ab167f8.

Signed-off-by: Monis Khan <mok@microsoft.com>
2022-09-23 12:00:14 -04:00
Kubernetes Prow Robot
5fe1450ba7
Merge pull request #112028 from dengyufeng2206/test2508
fix several typos under scheduler framework
2022-09-22 15:18:53 -07:00
Kubernetes Prow Robot
9cd59bfc38
Merge pull request #112660 from kerthcet/cleanup/change-approver
Make autoscaling team the autoscaler_contract package approver
2022-09-22 12:51:22 -07:00
kerthcet
2679d998d3 Make autoscaling team as the autoscaler_contract package approver
Signed-off-by: kerthcet <kerthcet@gmail.com>
2022-09-22 23:18:12 +08:00
Kubernetes Prow Robot
5ce4f98a76
Merge pull request #112579 from SergeyKanzhelev/removePodOverhead
remove podOverhead feature gate as a feature is now GA since 1.24
2022-09-22 07:59:04 -07:00
Kubernetes Prow Robot
d0a06a60a9
Merge pull request #112289 from electrocucaracha/add_tparallel-scheduling
Enable Parallel test execution in pkg/scheduler
2022-09-21 14:23:13 -07:00
Kubernetes Prow Robot
5e38528ef5
Merge pull request #110279 from sanposhiho/internal-cache
scheduler: Update cached Pod any time to make sure the Pod's status is up-to-date
2022-09-20 08:09:20 -07:00
Sergey Kanzhelev
ad7199a9da remove podOverhead feature gate as a feature is now GA since 1.24 2022-09-19 19:25:16 +00:00
Kensei Nakada
eba4d50c15 Update cached Pod to make sure the Pod's status is up-to-date 2022-09-17 14:32:08 +00:00
Kubernetes Prow Robot
3e5e5cc7ee
Merge pull request #112357 from SataQiu/deprecated-20220907
kube-scheduler: add taints filtering logic consistent with TaintToleration plugin for PodTopologySpread plugin
2022-09-16 18:14:27 -07:00
kerthcet
9a9fbf598e Fix calculating error when adding nominated pods in podTopologySpread
Signed-off-by: kerthcet <kerthcet@gmail.com>
2022-09-16 17:28:49 +08:00
Kubernetes Prow Robot
c5f795c8bf
Merge pull request #112222 from astraw99/fix-scheduler-misc
Update some scheduler misc
2022-09-14 18:37:22 -07:00
Victor Morales
f37ab167f8 Enable paralellism in scheduler unit tests
Unit tests run in parallel at the package level. This change allows the
execution of sig/scheduling unit tests in parallel.

Signed-off-by: Victor Morales <v.morales@samsung.com>
2022-09-14 14:20:56 -07:00
Kubernetes Prow Robot
3ac752e4a0
Merge pull request #112003 from sanposhiho/metrics-goroutine
feature(scheduler): add "goroutines" metric and deprecate the "scheduler_goroutines" metric
2022-09-12 12:01:16 -07:00
Kubernetes Prow Robot
6cf208e4d4
Merge pull request #112354 from pohly/volumebinding-delete-event-handler
volumebinding: handle special delete event in AssumeCache
2022-09-12 08:07:36 -07:00
SataQiu
bc9c494319 kube-scheduler: add taints filtering logic consistent with TaintToleration plugin for PodTopologySpread plugin
Signed-off-by: SataQiu <shidaqiu2018@gmail.com>
2022-09-10 09:04:30 +08:00
Kante Yin
096dafe757
Feat: unify the status handle when return in bindingCycle (#112103)
Signed-off-by: kerthcet <kerthcet@gmail.com>

Signed-off-by: kerthcet <kerthcet@gmail.com>
2022-09-09 08:31:23 -07:00
astraw99
ee24513e47 Fix scheduler misc 2022-09-04 00:07:49 +08:00
Kubernetes Prow Robot
904417b5d3
Merge pull request #110894 from yuanchen8911/prefilter
Consolidate PreFilter and Filter reason messages for scheduler
2022-09-02 16:34:27 -07:00
Kubernetes Prow Robot
f0fa987c05
Merge pull request #111544 from jlsong01/fix_resource_req_zero
fix pod created failed when resource request is 0
2022-09-02 10:56:05 -07:00
Patrick Ohly
c70203bda3 volumebinding: handle special delete event in AssumeCache
Sometimes an informer might not directly send the deleted object to the
OnDelete callback, but rather a DeletedFinalStateUnknown. The AssumeCache did
not handle that case.
2022-09-02 12:39:40 +02:00
Kubernetes Prow Robot
7f3f39b205
Merge pull request #112145 from chendave/fix_test
fix: `Node not found` when testcases is executed
2022-09-01 17:52:16 -07:00
Kubernetes Prow Robot
6e9845f766
Merge pull request #112146 from kerthcet/feat/move-schedulerError-to-api
Move constant schedulerError in scheduler to v1 package
2022-09-01 13:00:26 -07:00
kerthcet
71d0b89e3e Move constant schedulerError in scheduler to v1 package
Signed-off-by: kerthcet <kerthcet@gmail.com>
2022-09-01 23:43:20 +08:00
Kensei Nakada
08bd123b95 feature(scheduler): add "goroutines" metric and deprecate the "scheduler_goroutines" metric 2022-09-01 13:21:21 +00:00
Yuan Chen
cf28762aef Add PreFilter messages to Diagnosis
Address Wei Huang's comments

Define a separatorTemplate

Add test for scheduler FitError.Error()
2022-08-31 12:46:03 -07:00
Kubernetes Prow Robot
473229acf8
Merge pull request #112004 from sanposhiho/scheduler/remove-outdated-comments
cleanup(scheduler): remove outdated comments on metrics package
2022-08-31 12:29:06 -07:00
Kensei Nakada
d9835ae9c4 cleanup(scheduler): remove outdated comments on metrics package 2022-08-31 11:55:07 +00:00
Dave Chen
7533748bcc fix: Node not found when testcases is executed
Signed-off-by: Dave Chen <dave.chen@arm.com>
2022-08-31 18:28:48 +08:00
Kubernetes Prow Robot
04f8a5c41a
Merge pull request #111999 from kerthcet/refactor/handle-failure
fix error type when handling failures in scheduler
2022-08-30 05:47:01 -07:00
Kubernetes Prow Robot
4269caeffd
Merge pull request #111864 from kerthcet/cleanup/remove-untrue-comments
Remove not correct annotations with node.Spec.Unschedulable
2022-08-26 11:30:15 -07:00
Kubernetes Prow Robot
dbe3ac755a
Merge pull request #112029 from chendave/fix_status
Fix the wrong status returned from `RunPreFilterPlugins`
2022-08-25 23:34:50 -07:00
Dave Chen
8a288d6406 Fix the wrong status returned from RunPreFilterPlugins
event msg will be impacted due to the wrong status is returned.
e.g.

Warning  FailedScheduling ... running PreFilter plugin "PodTopologySpread": %!!(MISSING)w(<nil>)

Signed-off-by: Dave Chen <dave.chen@arm.com>
2022-08-26 11:20:11 +08:00
dengyufeng2206
1a07ea2f60 fix several typos under scheduler framework
Signed-off-by: dengyufeng2206 <deng.yufeng@zte.com.cn>
2022-08-25 19:02:07 +08:00
Yuan Chen
7e05c0a522 Log scheduling queue events
Fix a typo

Address comments

Log one more queue event

Update pkg/scheduler/internal/queue/scheduling_queue.go

Co-authored-by: Aldo Culquicondor <1299064+alculquicondor@users.noreply.github.com>

Update pkg/scheduler/internal/queue/scheduling_queue.go

Co-authored-by: Aldo Culquicondor <1299064+alculquicondor@users.noreply.github.com>

Address comments

Remove 'source' from scheudling queue events

Update scheduling queue event msg.

Update scheduling queue events
2022-08-24 16:47:14 -07:00
Kubernetes Prow Robot
9d9da4dc8b
Merge pull request #111968 from demoManito/fix/initmemory
Optimizing: make map cap
2022-08-24 09:36:03 -07:00
kerthcet
eeb6e791d9 fix error type
Signed-off-by: kerthcet <kerthcet@gmail.com>
2022-08-24 16:02:21 +08:00
Kubernetes Prow Robot
34aa4c39e0
Merge pull request #111845 from ialidzhikov/cleanup/pkg-scheduler
pkg/scheduler: Replace deprecated func usage from the `k8s.io/utils/pointer` pkg
2022-08-23 20:08:15 -07:00
Kubernetes Prow Robot
8c9c287533
Merge pull request #111826 from yuanchen8911/master
Add pod info.  KObj(pod) to scheduler cache log
2022-08-23 19:01:27 -07:00
Kubernetes Prow Robot
84f9aaaf5e
Merge pull request #111816 from kidddddddddddddddddddddd/feat/FlushAndExit
replace os.Exit with FlushAndExit
2022-08-23 19:01:19 -07:00
Kubernetes Prow Robot
ea4ff062ab
Merge pull request #111810 from Huang-Wei/sched-context-leak
Fix potential context leaking in scheduler
2022-08-23 19:01:12 -07:00
Kubernetes Prow Robot
626ff5c0c0
Merge pull request #111809 from Huang-Wei/retriable-sched-err
[sched] more error types when retry patching a pod's status
2022-08-23 19:01:05 -07:00
Kubernetes Prow Robot
5028dcb4ca
Merge pull request #111775 from sanposhiho/fix-cotext-leak
fix(scheduler): split scheduleOne into two functions for schedulingCycle and bindingCycle
2022-08-23 19:00:29 -07:00
Kubernetes Prow Robot
07bca2d791
Merge pull request #67782 from dims/yank-in-tree-openstack-cloud-provider
Remove in-tree openstack cloud provider
2022-08-23 18:59:48 -07:00
Kubernetes Prow Robot
15a5136c26
Merge pull request #111726 from Huang-Wei/debug-pendingpods
Expose a pending pods summary in scheudler's dummper output
2022-08-23 17:17:49 -07:00
Kubernetes Prow Robot
6c9c9ff851
Merge pull request #110717 from kerthcet/poc/ca-detector
Add Framework interface detectors in scheduler
2022-08-23 16:04:55 -07:00
Kubernetes Prow Robot
7424098eaf
Merge pull request #109945 from bells17/fix-error-message
Fix error message
2022-08-23 16:04:26 -07:00
Yuan Chen
974a41e55a Replace pod key with KObj(pod) in scheduler cache error msg
Add back pod key in scheduler cache

Add additional changes

Change podInfo to pod
2022-08-23 15:08:48 -07:00
demoManito
8ecb523b93 Optimize: code logic newNodeTree() 2022-08-23 17:37:39 +08:00
Davanum Srinivas
9bbf01bae9
Remove references to openstack and cinder
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2022-08-22 16:43:14 -04:00
Kensei Nakada
1538bbd73d fix(scheduler): split scheduleOne into two functions for schedulingCycle and bindingCycle 2022-08-19 14:09:18 +00:00
kerthcet
b27ceebc93 Remove out-of-date comments
Signed-off-by: kerthcet <kerthcet@gmail.com>
2022-08-16 14:05:11 +08:00
ialidzhikov
7c8a151faa pkg/scheduler: Replace deprecated func usage from the k8s.io/utils/pointer pkg 2022-08-16 08:39:18 +03:00
kidddddddddddddddddddddd
b5f0c34ef1 replace os.Exit with FlushAndExit 2022-08-12 17:34:13 +08:00
Wei Huang
a07e27082a
Fix potential context leaking in scheduler 2022-08-11 22:22:40 -07:00
Wei Huang
469e63eb5b
[sched] Add more retriable errors 2022-08-11 20:48:20 -07:00
amewayne
1457ad548c fix a memory leak problem when calling DryRunPreemption 2022-08-10 12:02:27 +08:00
Wei Huang
7df9bfcfef
Expose a pending pods summary in scheudler's dummper output 2022-08-05 22:02:38 -07:00
kerthcet
97e3e50493 Remove potential goroutine leak in NewFramework
Signed-off-by: kerthcet <kerthcet@gmail.com>
2022-08-06 00:05:22 +08:00
bells17
e539e04103 Use stretchr/testify/assert 2022-08-05 00:54:19 +09:00
Kubernetes Prow Robot
442574f3a7
Merge pull request #111513 from jingxu97/july/localstorage
Promote Local storage capacity isolation feature to GA
2022-08-03 13:05:59 -07:00
jinxu
0064010cdd Promote Local storage capacity isolation feature to GA
This change is to promote local storage capacity isolation feature to GA

At the same time, to allow rootless system disable this feature due to
unable to get root fs, this change introduced a new kubelet config
"localStorageCapacityIsolation". By default it is set to true. For
rootless systems, they can set this configuration to false to disable
the feature. Once it is set, user cannot set ephemeral-storage
request/limit because capacity and allocatable will not be set.

Change-Id: I48a52e737c6a09e9131454db6ad31247b56c000a
2022-08-02 23:45:48 -07:00
Kubernetes Prow Robot
369a465fae
Merge pull request #111301 from mattcary/migration-feature
Upgrade CSIMigrationGCE feature gate to GA
2022-08-02 13:58:57 -07:00
Matthew Cary
e5d387c5d6 Upgrade CSIMigrationGCE feature gate to GA
Change-Id: I620bc4913765c0d6562eb1008216a72e8b0a2970
2022-08-02 09:14:27 -07:00
jlsong01
27824fb06a fix pod created failed when resource request is 0 2022-08-02 23:41:53 +08:00
Michal Wozniak
04fcbd721c Introduction of a pod condition type indicating disruption. Its reason field indicates the reason:
- PreemptionByKubeScheduler (Pod preempted by kube-scheduler)
- DeletionByTaintManager (Pod deleted by taint manager due to NoExecute taint)
- EvictionByEvictionAPI (Pod evicted by Eviction API)
- DeletionByPodGC (an orphaned Pod deleted by PodGC)PreemptedByScheduler (Pod preempted by kube-scheduler)
2022-08-02 11:12:16 +02:00
Kubernetes Prow Robot
1e18ff5b37
Merge pull request #111479 from wongma7/migrationawsga
Promote CSIMigrationAWS to GA
2022-08-01 13:18:29 -07:00
Kubernetes Prow Robot
3902a53419
Merge pull request #111441 from denkensk/respect-topology
Respect PodTopologySpread after rolling upgrades
2022-07-30 01:40:42 -07:00
Kubernetes Prow Robot
2ae27c89ba
Merge pull request #111206 from SataQiu/scheduler-20220718
scheduler: include supported ScoringStrategyType list in error message for NodeResourcesFit plugin
2022-07-30 01:40:29 -07:00
Alex Wang
f4bc904376 implementation for MatchLabelKeys in TopologySpreadConstraint
Signed-off-by: Alex Wang <wangqingcan1990@gmail.com>
2022-07-30 13:23:49 +08:00
Matthew Wong
777f43062c Remove unit tests that set & test CSIMigrationAWS false since it's now locked to true 2022-07-29 13:52:06 -07:00
Kubernetes Prow Robot
442548a064
Merge pull request #110534 from kerthcet/feat/ga-component-config
Graduate component config to stable in kube-scheduler
2022-07-29 09:59:11 -07:00
Kubernetes Prow Robot
1865f7cb9b
Merge pull request #111287 from ldsdsy/modify1
Update the comment in pkg/scheduler/framework/plugins/noderesources
2022-07-29 08:35:11 -07:00
kerthcet
b3b6e0da0a Cleanup no longer fit comments
Signed-off-by: kerthcet <kerthcet@gmail.com>
2022-07-29 08:48:50 +08:00
kerthcet
02f77a1b84 Feat: ga component config in kube-scheduler
Signed-off-by: kerthcet <kerthcet@gmail.com>
2022-07-29 08:47:48 +08:00
Kubernetes Prow Robot
4cd1c80cea
Merge pull request #111139 from zhoumingcheng/master-u-v2
add unit test for pkg/kubelet/types/ func GetPodStartTime()
2022-07-27 11:34:52 -07:00
zhoumingcheng
9b6f880dbc add unit test for pkg/kubelet/types/ func GetPodStartTime()
Signed-off-by: zhoumingcheng <zhoumingcheng@beyondcent.com>
2022-07-27 09:26:56 +08:00
Davanum Srinivas
a9593d634c
Generate and format files
- Run hack/update-codegen.sh
- Run hack/update-generated-device-plugin.sh
- Run hack/update-generated-protobuf.sh
- Run hack/update-generated-runtime.sh
- Run hack/update-generated-swagger-docs.sh
- Run hack/update-openapi-spec.sh
- Run hack/update-gofmt.sh

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2022-07-26 13:14:05 -04:00
SataQiu
107dee6f04 scheduler: ValidateNodeResourcesFitArgs will check ScoringStrategy.Type field and print supported ScoringStrategyType list on error 2022-07-26 13:23:03 +08:00
Kubernetes Prow Robot
7b9a20b587
Merge pull request #111378 from kerthcet/revert/remove-plugin-logic
Revert "Cleanup: remove validation of removedPlugins"
2022-07-25 08:48:34 -07:00
kerthcet
aa04472f54 Refactor: rename removedPlugin to invalidPlugin
Signed-off-by: kerthcet <kerthcet@gmail.com>
2022-07-25 11:19:44 +08:00
kerthcet
a2229691a9 Revert "Cleanup: remove validation of removedPlugins"
This reverts commit 0971577c3e.
2022-07-25 10:56:05 +08:00
akankshakumari393
5d53407cc2 [Minor] Fix typos in the variable name in scheduling_queue_test.go 2022-07-23 19:27:15 +05:30
Kubernetes Prow Robot
765d6049c4
Merge pull request #111295 from Huang-Wei/reuse-err-eval-rst
sched: evaluate error message once
2022-07-21 12:59:50 -07:00
Wei Huang
65ce36d257
sched: evaluate error message once 2022-07-20 10:18:53 -07:00
ldsdsy
cc46cb002a Update the comment in pkg/scheduler/framework/plugins/noderesources/most_allocated.go 2022-07-20 21:38:50 +08:00
BinacsLee
14731ae1a7 cleanup: use sets.Clone() to avoid interim slice 2022-07-20 10:55:25 +08:00
kerthcet
a86bffedcf address comments
Signed-off-by: kerthcet <kerthcet@gmail.com>
2022-07-20 10:30:08 +08:00
kerthcet
c8360913ee Feat: add framework interface detector tests
Signed-off-by: kerthcet <kerthcet@gmail.com>
2022-07-19 18:16:56 +08:00
Kubernetes Prow Robot
b52705ae3e
Merge pull request #110663 from fromanirh/sched-allow-indexers
scheduler: framework: initialize indexers in scheduler core with non-nil map
2022-07-18 19:52:24 -07:00
Kubernetes Prow Robot
92cb0ae6ba
Merge pull request #109832 from sanposhiho/retry-on-update
Retry when it fails to update pods status on scheduling loop
2022-07-18 19:52:05 -07:00
Kubernetes Prow Robot
1c1efde70d
Merge pull request #109639 from Abirdcfly/fixduplicateimport
cleanup: remove all duplicate import
2022-07-18 16:55:23 -07:00
Kubernetes Prow Robot
590e84c097
Merge pull request #111203 from ldsdsy/modify3
Remove redundant code in pkg/scheduler/framework/plugins/volumebinding
2022-07-18 15:36:59 -07:00
Kubernetes Prow Robot
fdc7a5dd25
Merge pull request #111200 from ldsdsy/modify2
Format the code in pkg/scheduler/framework/plugins/noderesources
2022-07-18 15:36:52 -07:00
Kubernetes Prow Robot
93cb8fda4d
Merge pull request #111199 from zhoumingcheng/master-v6
Update error log to Error Wrapping
2022-07-18 15:36:44 -07:00
Kubernetes Prow Robot
93b6af95a0
Merge pull request #111153 from SataQiu/fix-scheduler-20220715
scheduler: remove useless null pointer check about nodeInfo for in-tree plugins
2022-07-18 15:36:37 -07:00
Kubernetes Prow Robot
e56cda48d3
Merge pull request #111047 from SataQiu/fix-scheduler-20220709
scheduler: improve the comment and add more unit test cases for DefaultNormalizeScore
2022-07-18 15:36:17 -07:00
ldsdsy
dbe1331371 Remove redundant code in pkg/scheduler/framework/plugins/volumebinding/volume_binding.go 2022-07-18 11:23:37 +08:00
ldsdsy
2f1168d9a5 Format the code in pkg/scheduler/framework/plugins/noderesources/balanced_allocation.go 2022-07-18 11:03:33 +08:00
zhoumingcheng
d5ed07c8eb Update error log to Error Wrapping
Signed-off-by: zhoumingcheng <zhoumingcheng@beyondcent.com>
2022-07-18 10:54:54 +08:00
Kubernetes Prow Robot
d6f4a5d04a
Merge pull request #111062 from SataQiu/fix-scheduler-20220711
scheduler: using math.MinInt64 instead of -math.MaxInt64
2022-07-15 10:42:18 -07:00
astraw99
e3ea17a97c fix pvc/pv update on binding pod volumes 2022-07-15 10:23:25 +08:00
Kubernetes Prow Robot
0e826ffef4
Merge pull request #111127 from HecarimV/fix-22071410
fix: update comment for related updated func
2022-07-14 13:19:08 -07:00
SataQiu
9a2eaa8e3f scheduler: improve the comment and add more unit test cases for DefaultNormalizeScore 2022-07-15 00:15:18 +08:00
SataQiu
97d9d2bd17 scheduler: remove useless null pointer check about nodeInfo for in-tree plugins 2022-07-15 00:09:42 +08:00
Kubernetes Prow Robot
b70f340209
Merge pull request #110958 from kidddddddddddddddddddddd/cleanup/remove-potential-goroutine-leak-in-binder
Pass context to pkg/scheduler/framework/plugins/volumebinding.
2022-07-13 22:50:56 -07:00
Abirdcfly
00b9ead02c cleanup: remove duplicate import
Signed-off-by: Abirdcfly <fp544037857@gmail.com>
2022-07-14 11:25:19 +08:00
HaoJie Liu
d8702cc369
fix: update comment for related updated func
Signed-off-by: HaoJie Liu <liuhaojie@beyondcent.com>
2022-07-14 10:20:48 +08:00
Francesco Romani
b4e015bf3c sched: schedfwk: init indexers with non-nil map
Using a nil map to initialize the pod indexers will
cause runtime failure when trying to add indexers
in scheduler plugin.
We use a empty map to enable scheduler plugins
to add their indexers.

Signed-off-by: Francesco Romani <fromani@redhat.com>
2022-07-13 09:24:57 +02:00
Wei Huang
4f77732540
merge MakeDefaultErrorFunc into handleSchedulingFailure 2022-07-12 12:11:16 -07:00
Kubernetes Prow Robot
098c733373
Merge pull request #111032 from kerthcet/cleanup/remove-validation-of-removed-plugins
Remove validation of removedPlugins in KubeSchedulerConfiguration
2022-07-12 08:32:14 -07:00
SataQiu
234dbf0318 scheduler: using math.MinInt64 instead of -math.MaxInt64 2022-07-11 14:53:18 +08:00
kerthcet
0971577c3e Cleanup: remove validation of removedPlugins
Signed-off-by: kerthcet <kerthcet@gmail.com>
2022-07-08 23:19:59 +08:00
HaoJie Liu
5639a4000f
Detailed printed error message
Signed-off-by: HaoJie Liu <liuhaojie@beyondcent.com>
2022-07-08 16:58:29 +08:00
Kubernetes Prow Robot
6adee9d4fb
Merge pull request #110947 from SataQiu/scheduler-20220704
scheduler: do not update sched.nextStartNodeIndex when evaluate nominated node
2022-07-07 07:57:45 -07:00
SataQiu
d3092cd296 scheduler: do not update sched.nextStartNodeIndex when evaluate nominated node 2022-07-07 10:02:28 +08:00
Kubernetes Prow Robot
1ea6eb2d1d
Merge pull request #110954 from kerthcet/fix/deadline-should-be-nil
Fix pod's deadline to nil when cache ttl is set to zero
2022-07-06 07:28:51 -07:00
Kubernetes Prow Robot
a17215fe84
Merge pull request #110768 from kerthcet/fix/filter-out-unsatisfied-nodes-in-AddPod
Filter out unsatisfied nodes when calling  AddPod in PodTopologySpread
2022-07-05 10:15:19 -07:00
kerthcet
72e8fc1d87 Fix: pod's deadline shoud be nil when cache ttl is 0
Signed-off-by: kerthcet <kerthcet@gmail.com>
2022-07-05 23:29:31 +08:00
kidddddddddddddddddddddd
c62479a6f1 Pass ctx to BindPodVolumes. 2022-07-05 20:23:07 +08:00
SataQiu
e74af4bdfa scheduler: remove unused Equal function for HTTPExtender 2022-07-05 13:17:05 +08:00
Kapil Jain
4706dda5da Added code for disable scheduler cache expiry 2022-07-04 23:46:59 +05:30
kerthcet
5a358f478b Fix: filter out unsatisfied nodes when calling AddPod in PodTopologySpread
Signed-off-by: kerthcet <kerthcet@gmail.com>
2022-07-01 11:46:26 +08:00
Yuan Chen
ef0456eb40 Refactor scheduler code 2022-06-30 11:27:25 -07:00
harry1064
fceb5cd4b1
Use clock package from k8s.io/utils/clock
- Remove unwanted clock.go file.
2022-06-25 00:25:12 +08:00
Kubernetes Prow Robot
18b5efceda
Merge pull request #110410 from Jiawei0227/master
CSIMigration feature gate to GA
2022-06-22 04:05:48 -07:00
Kubernetes Prow Robot
3d5971aa5d
Merge pull request #110167 from NoicFank/master
scheduling: fix duplicate checks for number of enabled queue sort plugin
2022-06-21 13:15:43 -07:00
Kubernetes Prow Robot
a57c140a12
Merge pull request #110567 from xiaomudk/patch-2
Remove redundant variable definitions in scheduler apis defaults.go
2022-06-21 09:46:25 -07:00
Kensei Nakada
8b18f7c869 Retry when update unschedulable pods status on scheduling loop 2022-06-17 19:09:30 +00:00
Kubernetes Prow Robot
597cb5fac8
Merge pull request #110202 from kerthcet/cleanup/remove-potential-goroutine-leak-in-utils
Using inherited context in utils
2022-06-14 09:09:34 -07:00
xiaomudk
8e7b6f3770 Remove redundant variable definitions in scheduler apis defaults.go 2022-06-14 22:36:00 +08:00
Kubernetes Prow Robot
c2139f724c
Merge pull request #110232 from kerthcet/cleanup/remove-potential-goroutine-leak-in-volumebinding
Pass context to client calls in scheduler/volumebinding tests
2022-06-13 22:21:32 -07:00
kerthcet
e54ce7c0c6 Cleanup: Pass context to client calls in scheduler/volumebinding tests
Signed-off-by: kerthcet <kerthcet@gmail.com>
2022-06-13 23:53:23 +08:00
xiaomudk
8187c2da9e Optimize code for SetDefaults_NodeResourcesBalancedAllocationArgs 2022-06-13 23:09:08 +08:00
Kubernetes Prow Robot
df92c0a6fb
Merge pull request #110493 from xiaomudk/remove-parentheses
clean: remove useless parentheses
2022-06-13 06:44:22 -07:00
xiaomudk
5826cae547 clean: remove useless parentheses 2022-06-10 00:09:50 +08:00
Jiawei Wang
760365d5c9 CSIMigration feature gate to GA 2022-06-06 21:19:19 +00:00
lokichoggio
60327c9090
code optimization 2022-06-06 14:23:42 +08:00
kerthcet
186470abd4 Cleanup: modify unmatch comments with stopCh
Signed-off-by: kerthcet <kerthcet@gmail.com>
2022-05-31 11:28:02 +08:00
Wojciech Tyczyński
fe3616cafb Clean shutdown of kcm, ccm and scheduler 2022-05-26 12:36:59 +02:00
kerthcet
67b0ce87fe Using inherited context in utils
This PR focus on utils in scheduler. When to patch pod status or delete pod,
it is better to use an inherited context.
Although this do not take a big effect in preventing goroutine leak, but it is a best practice

Signed-off-by: kerthcet <kerthcet@gmail.com>
2022-05-25 10:14:40 +08:00
Dingzhu Lurong
2499c240a9 remove duplicate checks for number of enabled queue sort plugin 2022-05-23 21:13:32 +08:00
Wojciech Tyczyński
7060953b92 Clear shutdown of scheduler metrics recorder 2022-05-20 20:23:29 +02:00
Kubernetes Prow Robot
71da53c28b
Merge pull request #108218 from cyclinder/remove_featuregate
remove featuregate in 1.25
2022-05-17 20:08:53 -07:00
bells17
4477be81e7 Fix error message
Update pkg/scheduler/framework/plugins/volumebinding/volume_binding_test.go

Oh...thanks.

Co-authored-by: Kensei Nakada <handbomusic@gmail.com>
2022-05-13 23:56:38 +09:00
Kubernetes Prow Robot
1be1ec4aa3
Merge pull request #109970 from stevekuznetsov/skuznets/isolate-versioner
storage: move the APIObjectVersioner definition to storage
2022-05-12 12:32:44 -07:00
cyclinder
6150737d11 remove feature gate GA for 1.25
Signed-off-by: cyclinder qifeng.guo@daocloud.io
2022-05-12 14:15:23 +08:00
Kubernetes Prow Robot
8aaea8e24c
Merge pull request #107787 from Jiawei0227/volumelimit
CSI migration doesn't count inline volumes for attach limit
2022-05-11 23:09:13 -07:00
Kubernetes Prow Robot
414990751e
Merge pull request #109519 from kerthcet/refactor/remove-unnecessary-code
cleanup: remove useless codes when checking Skip status
2022-05-11 13:27:02 -07:00
Steve Kuznetsov
3939f3003e
storage: move the APIObjectVersioner definition to storage
The means by which we extract and parse the version of an API object is
not specific to etcd3. In order to allow for a generic suite of tests
against any storage.Interface imlpementation, we need this logic to live
outside of the etcd3 package, or import cycles will exist.

Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
2022-05-11 08:19:32 -07:00
kerthcet
41e46a1bb4 cleanup: remove unnecessary codes
Signed-off-by: kerthcet <kerthcet@gmail.com>
2022-05-11 16:07:12 +08:00
kerthcet
790d983867 feat: implement NodeInclusionPolicy in TopologySpreadConstraint
Signed-off-by: kerthcet <kerthcet@gmail.com>
2022-05-11 07:51:18 +08:00
Kubernetes Prow Robot
cc66198570
Merge pull request #108492 from kerthcet/feature/add-NodeInclustionPolicies
Add NodeInclusionPolicy to TopologySpreadConstraint in PodSpec
2022-05-10 08:41:43 -07:00
Jiawei Wang
9d01f0bf52 Count inline volume for NodeVolumeLimit when CSI migration enabled
Previsouly, when kube-scheduler schedule a pod, it does
not take inline intree volume into account when CSI
migration is enabled. This could lead to failures where
pod scheduled to a node but volume attachment fails.
2022-05-10 07:43:28 +00:00
kerthcet
02f0a3ee91 feat: add NodeInclusionPolicy to TopologySpreadConstraint in PodSpec
Signed-off-by: kerthcet <kerthcet@gmail.com>
2022-05-10 12:54:49 +08:00
Kubernetes Prow Robot
b53be1d66e
Merge pull request #109879 from zzr93/master
wake up only when pod being added to activeQ
2022-05-09 09:09:18 -07:00
zzr93
923a99db95 unify wake up variable names to activated 2022-05-08 12:09:13 +08:00
Kubernetes Prow Robot
c8b3b293c0
Merge pull request #109756 from kidddddddddddddddddddddd/FilterOutPods_O_len
remove pkg/scheduler/framework/FilterOutPods since it's not used anymore
2022-05-07 04:41:17 -07:00
Kubernetes Prow Robot
c8cdf08191
Merge pull request #109684 from yibozhuang/test-cleanup
cleanup: move scheduler unit tests to use PodWrapper
2022-05-06 21:15:16 -07:00