Commit Graph

113883 Commits

Author SHA1 Message Date
Francesco Romani
00b41334bf e2e: node: podresources: fix restart wait
Fix the waiting logic in the e2e test loop to wait
for resources to be reported again instead of making logic on the
timestamp. The idea is that waiting for resource availability
is the canonical way clients should observe the desired state,
and it should also be more robust than comparing timestamps,
especially on CI environments.

Signed-off-by: Francesco Romani <fromani@redhat.com>
2023-02-22 14:04:55 +01:00
Francesco Romani
92e00203e0 e2e: node: unify sample device plugin utilities
Start to consolidate the sample device plugin utility
and constants in a central place, because we need
to use it in different e2e tests.

Having a central dependency is better than a maze of
entangled e2e tests depending on each other helpers.

Signed-off-by: Francesco Romani <fromani@redhat.com>
2023-02-22 14:04:55 +01:00
Francesco Romani
871201ba64 e2e: node: remove kubevirt device plugin
The podresources e2e tests want to exercise the case on which a device
plugin doesn't report topology affinity. The only known device plugin
which had this requirement and didn't depend on specialized hardware
was the kubevirt device plugin, which was however deprecated after
we started using it.

So the e2e tests are now broken, and in any case they can't depend on
unmaintained and liable to be obsolete code.

To unblock the state and preserve some e2e signal, we switch to the
sample device plugin, which is a stub implementation and which is
managed in-tree, so we can maintain it and ensure it fits the e2e test
usecase.

This is however a regression, because e2e tests should try their hardest
to use real devices and avoid any mocking or faking.
The upside is that using a OS-neutral device plugin for the tests enables
us to run on all the supported platform (windows!) so this could allow
us to transition these tests to conformance.

Signed-off-by: Francesco Romani <fromani@redhat.com>
2023-02-22 14:04:22 +01:00
Francesco Romani
aa1a0385e2 e2e: node: podresources: internal cleanup
rename getPodResources for clarity. Allow to return error
(and not use ginkgo expectations), so it can actually be used
as intended inside `Eventually` blocks without blow up at the
first failure.

Signed-off-by: Francesco Romani <fromani@redhat.com>
2023-02-22 13:49:13 +01:00
Kubernetes Prow Robot
e29d3229cc
Merge pull request #115272 from thockin/codegen-mocks-neg-glob
Fix update-mocks to use better globs
2023-02-20 09:39:49 -08:00
Kubernetes Prow Robot
5a2922474c
Merge pull request #115905 from cpanato/update-iptable
update distroless iptables to v0.2.1
2023-02-20 05:47:48 -08:00
cpanato
a2c5863adc
update distroless iptables to v0.2.1
Signed-off-by: cpanato <ctadeu@gmail.com>
2023-02-20 13:44:09 +01:00
Kubernetes Prow Robot
bd914b493c
Merge pull request #115676 from chendave/conversion_api
kubeadm: remove the manual conversion from versioned cluster cfg to internal cfg
2023-02-20 02:53:48 -08:00
Kubernetes Prow Robot
9e356a4132
Merge pull request #115719 from saschagrunert/seccomp-default-ga
Graduate `SeccompDefault` feature to stable / GA
2023-02-20 01:11:51 -08:00
Kubernetes Prow Robot
1bc34fe339
Merge pull request #115571 from ardaguclu/diff-prune-l-test
Add integration test for diff --prune --selector
2023-02-20 01:11:39 -08:00
Kubernetes Prow Robot
1d02d014e8
Merge pull request #115839 from wedaly/kubectl-netadmin-unit-test-followup
kubectl: add unit tests for kubectl debug profiles
2023-02-19 22:39:38 -08:00
Arda Güçlü
6c346e6cc9 Re-enable label selector 2023-02-20 09:10:51 +03:00
Arda Güçlü
6e8a1beda7 Add integration test for diff --prune --selector
This PR adds new integration tests for `kubectl diff --prune -l` to
catch possible regressions in the future.
2023-02-20 09:10:50 +03:00
Kubernetes Prow Robot
d6fe718e19
Merge pull request #115800 from shogohida/switch-image-in-grpc-probe-tests-to-agnhost
Switch image in gRPC probe tests to agnhost
2023-02-18 10:19:36 -08:00
Shogo Hida
7cbf007e47 Fix port number
Signed-off-by: Shogo Hida <shogo.hida@gmail.com>
2023-02-18 20:44:10 +09:00
Kubernetes Prow Robot
70b2e4aa3e
Merge pull request #113312 from jiahuif-forks/feature/cel/builtins
OpenAPI-based CEL type library
2023-02-18 00:31:36 -08:00
Shogo Hida
26f95f475a Fix arguments
Signed-off-by: Shogo Hida <shogo.hida@gmail.com>
2023-02-18 09:51:17 +09:00
Kubernetes Prow Robot
1c97dbc8c9
Merge pull request #115809 from seans3/openapi-file-client
New openapi v3 testing file client
2023-02-17 09:00:16 -08:00
Kubernetes Prow Robot
8014155cb5
Merge pull request #115472 from lanycrost/client-go-110992-GenerateSelfSignedCertKeyWithFixtures-permissions
client-go: make generating certificate/key permissions more restrictive (600)
2023-02-17 09:00:03 -08:00
Kubernetes Prow Robot
3165fe19b3
Merge pull request #115255 from dims/remove-unnecessary-ETCD_UNSUPPORTED_ARCH-for-arm64
Remove unnecessary ETCD_UNSUPPORTED_ARCH for arm64
2023-02-17 05:44:15 -08:00
Kubernetes Prow Robot
d9ed2ff4b0
Merge pull request #114687 from freddie400/migrate-hpa
Migrate pkg/controller/podautoscaler to contextual logging
2023-02-17 05:44:03 -08:00
Kubernetes Prow Robot
c97512fe2a
Merge pull request #115855 from cpanato/update-publishig
update go to 1.19.6 in publishing bot rules for active release branches
2023-02-17 04:03:57 -08:00
Khachatur Ashotyan
49af62e64f
client-go: change permissions of key 2023-02-17 14:21:24 +04:00
cpanato
8bbd1a77c7
update go to 1.19.6 in publishing bot rules for active release branches
Signed-off-by: cpanato <ctadeu@gmail.com>
2023-02-17 10:23:19 +01:00
Khachatur Ashotyan
3cc99c5e77 client-go: change permissions of GenerateSelfSignedCertKeyWithFixtures generated cert 2023-02-17 11:20:39 +04:00
Khachatur Ashotyan
c941877438 client-go: change permissions of directories and certs 2023-02-17 11:16:46 +04:00
Kubernetes Prow Robot
e55f2a9b54
Merge pull request #112393 from borgerli/apf-pl-dump
APF: two improvements when dumping priority levels
2023-02-16 19:33:48 -08:00
Davanum Srinivas
4ecb4670cc
Remove unnecessary ETCD_UNSUPPORTED_ARCH for arm64
we should only use this env var for `arm`, since `arm64` is fully
supported by etcd folks, let us drop this!

(ex - https://github.com/etcd-io/etcd/releases/tag/v3.5.6)

ppc64le comment should be dropped as well

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2023-02-16 21:29:13 -05:00
Kubernetes Prow Robot
814faade7f
Merge pull request #115620 from odinuge/ou-relist-missing-delete
client-go/cache: fix missing delete event on replace
2023-02-16 16:09:37 -08:00
Will Daly
21e8d29581 kubectl: add unit tests for kubectl debug profiles
Unit test netadmin profile preserves existing capabilities.
Unit test debug profiles in TestGenerateNodeDebugPod
Unit test debug profiles in TestGeneratePodCopyWithDebugContainer
Organize Go imports in unit tests

Signed-off-by: Will Daly <widaly@microsoft.com>
2023-02-16 16:00:28 -08:00
Sean Sullivan
195a55c84c New openapi v3 testing file client 2023-02-16 12:52:14 -08:00
Freddie
dee494ece1 squashing without rebase 2023-02-17 01:47:52 +05:30
Kubernetes Prow Robot
894cfdfeb4
Merge pull request #115363 from ravisantoshgudimetla/promote-pdb-healthy
Promote pdb healthy to beta
2023-02-16 11:45:49 -08:00
Kubernetes Prow Robot
7d681c96a3
Merge pull request #113263 from andrewsykim/fix-flaky-flowcontrol-queueset-test
[Flaky test] fix floating point precision error in TestDifferentWidths
2023-02-16 11:45:37 -08:00
Kubernetes Prow Robot
4c4f0c3a20
Merge pull request #115837 from wedaly/kubectl-netadmin-pointer-bool
kubectl: use pointer.Bool instead of deprecated pointer.BoolPtr
2023-02-16 09:56:03 -08:00
Kubernetes Prow Robot
5c09c9de29
Merge pull request #115828 from cpanato/go1201
[go] Bump images, dependencies and versions to go 1.20.1
2023-02-16 09:55:56 -08:00
Kubernetes Prow Robot
bce513a2b8
Merge pull request #115821 from lianghao208/scheduling_gate_name_format
Validating the scheduling gate name qualified
2023-02-16 09:55:49 -08:00
Kubernetes Prow Robot
ffe410bbb4
Merge pull request #115604 from pacoxu/fix-design-proposals-links
old design proposals are now moved to Design Proposals Archive repo
2023-02-16 09:55:38 -08:00
Kubernetes Prow Robot
d004f324d3
Merge pull request #114447 from yulng/elseyw
fix:Optimize code for else logic
2023-02-16 08:33:40 -08:00
Kubernetes Prow Robot
cd5ab49741
Merge pull request #115713 from SataQiu/clean-20230213
cleanup: using const systemNodeRoleName instead of string "system:node"
2023-02-16 07:21:50 -08:00
Kubernetes Prow Robot
9269aaada2
Merge pull request #114201 from Octopusjust/k8s-pr20
change unnecessary `switch` to `if` in metrics.go
2023-02-16 07:21:38 -08:00
Will Daly
4101b79606
kubectl: use pointer.Bool instead of deprecated pointer.BoolPtr
Signed-off-by: Will Daly <widaly@microsoft.com>
2023-02-16 06:47:33 -08:00
cpanato
65230338ad
[go] Bump images, dependencies and versions to go 1.20.1
Signed-off-by: cpanato <ctadeu@gmail.com>
2023-02-16 13:38:32 +01:00
Kubernetes Prow Robot
77af0be42f
Merge pull request #115519 from sanposhiho/move-metric-recorder
cleanup(scheduler): move metricRecorder to metrics package
2023-02-16 03:57:38 -08:00
ZhangYu
48b9f7bb6c change unnecessary switch to if in metrics.go 2023-02-16 18:37:53 +08:00
Kubernetes Prow Robot
1e84987bac
Merge pull request #115799 from pohly/test-util-data-race
test/utils: avoid data race during parallel create
2023-02-16 01:53:38 -08:00
Kubernetes Prow Robot
8e31885e36
Merge pull request #115575 from SataQiu/fix-20230207
kubeadm: fix a bug where the uploaded kubelet configuration in kube-system/kubelet-config ConfigMap does not respect user patch
2023-02-16 00:45:38 -08:00
Patrick Ohly
501a7678b3 test/utils: avoid data race during parallel create
The client-go Create call writes into the object that it gets passed. Each call
therefore needs its own copy when invoked in parallel.

Seen in

   go test -v -timeout=0 -bench=.*/SchedulingBasic/5000Nodes -race ./test/integration/scheduler_perf

WARNING: DATA RACE
Read at 0x00c003fa5b00 by goroutine 45227:
  k8s.io/apimachinery/pkg/apis/meta/v1.(*TypeMeta).GroupVersionKind()
      /nvme/gopath/src/k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/apis/meta/v1/meta.go:126 +0x84
  k8s.io/apimachinery/pkg/runtime.WithVersionEncoder.Encode()
      /nvme/gopath/src/k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/runtime/helper.go:231 +0x176
  k8s.io/apimachinery/pkg/runtime.(*WithVersionEncoder).Encode()
      <autogenerated>:1 +0xfb
  k8s.io/apimachinery/pkg/runtime.Encode()
      /nvme/gopath/src/k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/runtime/codec.go:50 +0xb3
  k8s.io/client-go/rest.(*Request).Body()
      /nvme/gopath/src/k8s.io/kubernetes/vendor/k8s.io/client-go/rest/request.go:469 +0x884
  k8s.io/client-go/kubernetes/typed/core/v1.(*pods).Create()
      /nvme/gopath/src/k8s.io/kubernetes/vendor/k8s.io/client-go/kubernetes/typed/core/v1/pod.go:126 +0x264
  k8s.io/kubernetes/test/utils.CreatePodWithRetries.func1()
      /nvme/gopath/src/k8s.io/kubernetes/test/utils/create_resources.go:61 +0x111
  k8s.io/apimachinery/pkg/util/wait.ConditionFunc.WithContext.func1()
      /nvme/gopath/src/k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:222 +0x30
  k8s.io/apimachinery/pkg/util/wait.runConditionWithCrashProtectionWithContext()
      /nvme/gopath/src/k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:262 +0x7b
  k8s.io/apimachinery/pkg/util/wait.runConditionWithCrashProtection()
      /nvme/gopath/src/k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:255 +0x5c
  k8s.io/apimachinery/pkg/util/wait.ExponentialBackoff()
      /nvme/gopath/src/k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:431 +0x67
  k8s.io/kubernetes/test/utils.RetryWithExponentialBackOff()
      /nvme/gopath/src/k8s.io/kubernetes/test/utils/create_resources.go:53 +0x1be
  k8s.io/kubernetes/test/utils.CreatePodWithRetries()
      /nvme/gopath/src/k8s.io/kubernetes/test/utils/create_resources.go:70 +0x1bf
  k8s.io/kubernetes/test/utils.makeCreatePod()
      /nvme/gopath/src/k8s.io/kubernetes/test/utils/runners.go:1339 +0x68
  k8s.io/kubernetes/test/utils.CreatePod.func1()
      /nvme/gopath/src/k8s.io/kubernetes/test/utils/runners.go:1349 +0xab
  k8s.io/client-go/util/workqueue.ParallelizeUntil.func1()
      /nvme/gopath/src/k8s.io/kubernetes/vendor/k8s.io/client-go/util/workqueue/parallelizer.go:90 +0x1c1

Previous write at 0x00c003fa5b00 by goroutine 45250:
  k8s.io/apimachinery/pkg/apis/meta/v1.(*TypeMeta).SetGroupVersionKind()
      /nvme/gopath/src/k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/apis/meta/v1/meta.go:121 +0x1cc
  k8s.io/apimachinery/pkg/runtime.WithVersionEncoder.Encode()
      /nvme/gopath/src/k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/runtime/helper.go:241 +0x408
  k8s.io/apimachinery/pkg/runtime.(*WithVersionEncoder).Encode()
      <autogenerated>:1 +0xfb
  k8s.io/apimachinery/pkg/runtime.Encode()
      /nvme/gopath/src/k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/runtime/codec.go:50 +0xb3
  k8s.io/client-go/rest.(*Request).Body()
      /nvme/gopath/src/k8s.io/kubernetes/vendor/k8s.io/client-go/rest/request.go:469 +0x884
  k8s.io/client-go/kubernetes/typed/core/v1.(*pods).Create()
      /nvme/gopath/src/k8s.io/kubernetes/vendor/k8s.io/client-go/kubernetes/typed/core/v1/pod.go:126 +0x264
  k8s.io/kubernetes/test/utils.CreatePodWithRetries.func1()
      /nvme/gopath/src/k8s.io/kubernetes/test/utils/create_resources.go:61 +0x111
  k8s.io/apimachinery/pkg/util/wait.ConditionFunc.WithContext.func1()
      /nvme/gopath/src/k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:222 +0x30
  k8s.io/apimachinery/pkg/util/wait.runConditionWithCrashProtectionWithContext()
      /nvme/gopath/src/k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:262 +0x7b
  k8s.io/apimachinery/pkg/util/wait.runConditionWithCrashProtection()
      /nvme/gopath/src/k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:255 +0x5c
  k8s.io/apimachinery/pkg/util/wait.ExponentialBackoff()
      /nvme/gopath/src/k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:431 +0x67
  k8s.io/kubernetes/test/utils.RetryWithExponentialBackOff()
      /nvme/gopath/src/k8s.io/kubernetes/test/utils/create_resources.go:53 +0x1be
  k8s.io/kubernetes/test/utils.CreatePodWithRetries()
      /nvme/gopath/src/k8s.io/kubernetes/test/utils/create_resources.go:70 +0x1bf
  k8s.io/kubernetes/test/utils.makeCreatePod()
      /nvme/gopath/src/k8s.io/kubernetes/test/utils/runners.go:1339 +0x68
  k8s.io/kubernetes/test/utils.CreatePod.func1()
      /nvme/gopath/src/k8s.io/kubernetes/test/utils/runners.go:1349 +0xab
  k8s.io/client-go/util/workqueue.ParallelizeUntil.func1()
      /nvme/gopath/src/k8s.io/kubernetes/vendor/k8s.io/client-go/util/workqueue/parallelizer.go:90 +0x1c1
2023-02-16 08:44:42 +01:00
Kubernetes Prow Robot
6a5c88b9dd
Merge pull request #115712 from wedaly/kubectl-netadmin-debug-profile
kubectl debug: add netadmin profile
2023-02-15 23:39:38 -08:00
Paco Xu
3d536bd14b API docs: point to current docs instead of archived designs 2023-02-16 15:32:08 +08:00