Commit Graph

45402 Commits

Author SHA1 Message Date
Yu-Ju Hong
056e343e03 node e2e: improve the validate OOM score test for infra containers
The test blindly checked all "pause" processes on the node, assuming
they were all infra containers. This change takes a snapshot of all
existing "pause" processes on the node, and exclude them in the
validation. The test still relies on the fact that it runs exclusively
on the node. If that assumption changes, we will need other methods to
locate the PIDs of the infra containers.
2017-03-16 15:39:03 -07:00
Kubernetes Submit Queue
67a6c68d77 Merge pull request #43089 from krousey/upgrades
Automatic merge from submit-queue

Add guards for StatefulSet and AppArmor upgrade testing

This PR adds automated upgrade infrastructure to allow test suites to know what versions and node images are going to be testing and whether or not they should be skipped. It also adds a guard to prevent StatefulSets from being tested with versions prior to 1.5.0, and a guard to prevent AppArmor from running on distros other than gci and ubuntu.
2017-03-16 09:26:56 -07:00
Kubernetes Submit Queue
b617cabfca Merge pull request #43192 from liggitt/kubectl-test-retry
Automatic merge from submit-queue

Retry kubectl test replace on conflict

Since kubectl is doing a resource-version-constrained replace, it is subject to conflicts on a contentious resource (like a node managed by the node controller)

Fixes #41892 (the specific flake, not the watch cache issue)
2017-03-16 08:23:21 -07:00
Kubernetes Submit Queue
40ef612781 Merge pull request #43202 from jsafrane/rename-storageclass
Automatic merge from submit-queue (batch tested with PRs 43177, 43202)

Rename default storageclasses

From UX perspective, 'default' is a bad name for the default storage class:

```
$ kubectl get storageclass
NAME                TYPE
default (default)   kubernetes.io/aws-ebs
```

This is sort of OK, it gets more confusing when user is not happy with the
preinstalled default storage class and creates its own and makes it default:

```
NAME             TYPE
default          kubernetes.io/aws-ebs
iops (default)   kubernetes.io/aws-ebs
```

This PR uses name of the underlying storage as name of the default storage class:

```
NAME            TYPE
gp2 (default)   kubernetes.io/aws-ebs
```

On GCE (and many others):
```
NAME                 TYPE
standard (default)   kubernetes.io/gce-pd
```

Detailed list of names of new default storage classes:

* AWS: `gp2`
* GCE: `standard` (from pd-standard)
* vSphere: `thin`

* Cinder does not have a default - it's up to OpenStack admin to set some default and it can change at any time, using `standard` as the class name.
* I was not able to find details about Azure, using `standard` too.

@justinsb @jingxu97 @kerneltime @colemickens, PTAL quickly so we can catch 1.6.

```release-note
NONE
```

For 1.6 release manager, this PR just renames objects in addon manager.
2017-03-16 07:36:19 -07:00
Kubernetes Submit Queue
47bea96b04 Merge pull request #43177 from mml/file-exists!
Automatic merge from submit-queue

Force create symlinks.

Followup from #43070.  Fixes #42660 in a way that does not break etcd upgrades.
2017-03-16 06:58:49 -07:00
Jordan Liggitt
9cd791e83c
Retry kubectl test replace on conflict 2017-03-16 08:39:47 -04:00
Kubernetes Submit Queue
b1cac347f7 Merge pull request #43186 from mwielgus/ca-0.5.0-b2
Automatic merge from submit-queue

Bump cluster autoscaler to 0.5.0-beta2

**What this PR does / why we need it**:

This part is a part of Cluster Autoscaler release process for 1.6.0. It contains couple of bugfixes on top of 0.5.0-beta1. Hopefully this will be the last beta before final bump to 0.5.0

cc: @MaciekPytel @jszczepkowski @fgrzadkowski
2017-03-16 02:41:19 -07:00
Kubernetes Submit Queue
754effe332 Merge pull request #42949 from wenlxie/master
Automatic merge from submit-queue

recycle pod can't get the event since channel closed

What this PR does / why we need it:
We create a   hostPath type  PV with "Recycle" persistentVolumeReclaimPolicy,  and bind a PVC to it, but after deleted the PVC, the PV cannot become to available status. This is happened after we upgrade etcd to 3.0. The reason is:
If the channel used to get the pod message and events been abnormal closed(for example, the event channel maybe closed because of "required revision has been compacted" error), the function internalRecycleVolumeByWatchingPodUntilCompletion will stuck in a loop, and the recycle pod will not been deleted, the PV can not become into available status

Special notes for your reviewer:
None
Release note:
2017-03-16 02:41:11 -07:00
Jan Safranek
5046514797 Rename default storageclasses
From UX perspective, 'default' is a bad name for the default storage class:

$ kubectl get storageclass
NAME            TYPE
default (default)   kubernetes.io/aws-ebs

This is sort of OK, it gets more confusing when user is not happy with the
preinstalled default storage class and creates its own and makes it default:

NAME             TYPE
default          kubernetes.io/aws-ebs
iops (default)   kubernetes.io/aws-ebs
2017-03-16 09:14:12 +01:00
Kubernetes Submit Queue
d1e6638a07 Merge pull request #43086 from liggitt/examples-permissions
Automatic merge from submit-queue (batch tested with PRs 43122, 43086)

Configure example pod namespaces

Fixes #43015 
Fixes #43019
Fixes #38222
2017-03-15 22:07:19 -07:00
Kubernetes Submit Queue
2bec20ce55 Merge pull request #43122 from liggitt/protobuf-default
Automatic merge from submit-queue

Prevent protobuf storage with etcd2

Prevents accidentally storing protobuf content in etcd2 when upgrading to 1.6

c.f. https://github.com/kubernetes/kubernetes/issues/42976#issuecomment-286537139

```release-note
if kube-apiserver is started with `--storage-backend=etcd2`, the media type `application/json` is used.
```
2017-03-15 22:07:03 -07:00
Kubernetes Submit Queue
5139da2d95 Merge pull request #42928 from bsalamat/e2e_flake_predicates
Automatic merge from submit-queue (batch tested with PRs 43180, 42928)

Fix waitForScheduler in scheduer predicates e2e tests

**What this PR does / why we need it**: Fixes waitForScheduler in e2e to resolve flaky tests in scheduler_predicates.go

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #42691

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```
2017-03-15 19:58:22 -07:00
Kubernetes Submit Queue
1357cafa71 Merge pull request #43180 from mbohlool/bugfix
Automatic merge from submit-queue (batch tested with PRs 43180, 42928)

Verify generated protobuf script should fail on staging/ changes too

fixes #35486
2017-03-15 19:58:20 -07:00
Kubernetes Submit Queue
ae828c9c6c Merge pull request #43157 from msau42/default-sc-test
Automatic merge from submit-queue (batch tested with PRs 43162, 43157)

Use beta default class annotation for default storageclass tests.

**What this PR does / why we need it**:
The default storageclasses are still installed with the beta annotation, so the test should explicitly use the beta annotation.

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #43150

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```
2017-03-15 18:24:21 -07:00
Marcin Wielgus
39d5a321f7 Bump cluster autoscaler to 0.5.0-beta2 2017-03-16 01:59:38 +01:00
Kubernetes Submit Queue
5bd730645c Merge pull request #43162 from fejta/own
Automatic merge from submit-queue

Add saad-ali and marun to test/OWNERS

/assign @saad-ali @marun 

Also ensure that approvers are in the reviewer list, and sort both lists.
2017-03-15 17:38:11 -07:00
Bobby Salamat
2775a52e7a Fix waitForScheduler in scheduer predicates e2e tests 2017-03-15 17:21:35 -07:00
Kris
3d05080982 Skip AppArmor tests on unsupported distros 2017-03-15 17:04:06 -07:00
Kris
c0ecd93801 Change the skipping mechanism to be more generic
And convert StatefulSet's version skipping to the new API.
2017-03-15 17:04:06 -07:00
mbohlool
f6e4c99548 Verify generated protobuf script should fail on staging/ changes too 2017-03-15 16:15:02 -07:00
Kubernetes Submit Queue
7e0b68239f Merge pull request #43115 from timstclair/summary-test
Automatic merge from submit-queue (batch tested with PRs 40964, 42967, 43091, 43115)

Add process debug information to summary test

Print out the processes in each system cgroup when the Summary API test fails, to help debug https://github.com/kubernetes/kubernetes/issues/40607

/cc @yujuhong @Random-Liu
2017-03-15 16:08:29 -07:00
Kubernetes Submit Queue
e4796bcf6b Merge pull request #43091 from gnufied/fix-dswp-flake
Automatic merge from submit-queue (batch tested with PRs 40964, 42967, 43091, 43115)

fixes dswp flake

Sometimes a pod may not appear in desired state
of world immediately, we poll before failing.

It only adds additional 30s to tests in worst case.

Fixes #42990 

cc @jingxu97
2017-03-15 16:08:27 -07:00
Kubernetes Submit Queue
6d2defbc09 Merge pull request #42967 from cblecker/godep-version79
Automatic merge from submit-queue (batch tested with PRs 40964, 42967, 43091, 43115)

Update hack scripts to use godep v79 and ensure_godep_version

**What this PR does / why we need it**:
Based on #42965 and https://github.com/kubernetes/kubernetes/pull/42958#discussion_r105568318, this pins the godep version at v79, which should fix some issues when running godep in go1.8 local environments.

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #42817

**Special notes for your reviewer**:
This should likely get the v1.6 milestone so that it can be merged into master. While I'm setting a default godep version, I'm continuing to use the local pins per this comment: https://github.com/kubernetes/kubernetes/pull/42965#issuecomment-285962723 .

**Release note**:

```release-note
NONE
```

cc: @sttts
2017-03-15 16:08:25 -07:00
Kubernetes Submit Queue
ba25afd278 Merge pull request #40964 from tanshanshan/kubelet-unit-test
Automatic merge from submit-queue (batch tested with PRs 40964, 42967, 43091, 43115)

Improve code coverage for pkg/kubelet/status/generate.go

**What this PR does / why we need it**:

Improve code coverage for pkg/kubelet/status/generate.go  from #39559

Thanks.

**Special notes for your reviewer**:

**Release note**:

```release-note
```
2017-03-15 16:08:23 -07:00
Matt Liggett
c79d74f382 Force create symlinks. 2017-03-15 14:03:46 -07:00
Erick Fejta
cd91502df0 Add saad-ali and marun to test/OWNERS 2017-03-15 13:25:11 -07:00
Michelle Au
3fd61fbfe1 Use beta default class annotation for default storageclass tests. 2017-03-15 11:44:14 -07:00
Kubernetes Submit Queue
355f576c0b Merge pull request #43107 from intelsdi-x/guarantee-watch-before-action
Automatic merge from submit-queue

Guarantee watch before action in e2e event observer helper function.

**What this PR does / why we need it**:

Adds a missing synchronization barrier to an e2e event observation helper function.

- This change should guarantee that in observeEventAfterAction,
  the action is only executed after the informer begins watching
  the event stream.

**Release note**:

```release-note
NONE
```

cc @kubernetes/sig-scheduling-pr-reviews @bsalamat
2017-03-15 11:09:20 -07:00
Christoph Blecker
4d85a54027
Change verify-godeps.sh use ensure_godep_version 2017-03-15 10:32:44 -07:00
Christoph Blecker
d31a88fee7
Bump godep version to v79 2017-03-15 10:32:37 -07:00
Kubernetes Submit Queue
fb243a4b57 Merge pull request #43117 from crassirostris/fix-es-cluster-logging-tests
Automatic merge from submit-queue (batch tested with PRs 40404, 43134, 43117)

Fix ES cluster logging test

Fix #37324

Test was broken because fluentd-gcp now parses golang and fluentd-es doesn't
2017-03-15 08:27:28 -07:00
Kubernetes Submit Queue
4c5d50e98a Merge pull request #43134 from shyamjvs/fix-configure-script
Automatic merge from submit-queue (batch tested with PRs 40404, 43134, 43117)

Add -p to mkdirs in gci-mounter function of gce configure.sh script

Ref https://github.com/kubernetes/kubernetes/issues/40139#issuecomment-286068409

cc @wojtek-t
2017-03-15 08:27:22 -07:00
Kubernetes Submit Queue
9e8114655f Merge pull request #40404 from tanshanshan/unit-test-scheduler4
Automatic merge from submit-queue (batch tested with PRs 40404, 43134, 43117)

Improve code coverage for scheduler/api/validation

**What this PR does / why we need it**:

Improve code coverage for scheduler/api/validation from #39559

Thanks
**Special notes for your reviewer**:

**Release note**:

```release-note
```
2017-03-15 08:27:20 -07:00
Jordan Liggitt
87e32c7532
Force etcd2 to use application/json, add base64-wrapper decoder as fallback 2017-03-15 11:24:12 -04:00
Hemant Kumar
1a6c36da53 Fix dswp flake - from pod not showing in dswp
Sometimes a pod may not appear in desired state
of world immediately, we poll before failing.

It only adds additional 30s to tests in worst case.
2017-03-15 10:12:25 -04:00
Kubernetes Submit Queue
0afdcfcaf6 Merge pull request #43114 from enisoc/deployment-upgrade-test
Automatic merge from submit-queue

Fix Deployment upgrade test.

**What this PR does / why we need it**:

When the upgrade test operates on Deployments in a pre-1.6 cluster (i.e. during the Setup phase), it needs to use the v1.5 deployment/util logic. In particular, the v1.5 logic does not filter children to only those with a matching ControllerRef.

**Which issue this PR fixes**:

Fixes #42738

**Special notes for your reviewer**:

**Release note**:
```release-note
```
cc @kubernetes/sig-apps-pr-reviews
2017-03-15 07:03:19 -07:00
Kubernetes Submit Queue
df97434e8a Merge pull request #43110 from caesarxuchao/fix-42952
Automatic merge from submit-queue (batch tested with PRs 43106, 43110)

Wait for garbagecollector to be synced in test

Fix #42952

Without the `cache.WaitForCacheSync` in the test, it's possible for the GC to get a merged event of RC's creation and its update (update to deletionTimestamp != 0), before GC gets the creation event of the pod, so it's possible the GC will handle the foreground deletion of the RC before it adds the Pod to the dependency graph, thus the race.

With the `cache.WaitForCacheSync` in the test, because GC runs a single thread to process graph changes, it's guaranteed the Pod will be added to the dependency graph before GC handles the foreground deletion of the RC.

Note that this pull fixes the race in the test. The race described in the first point of #26120 still exists.
2017-03-15 06:14:21 -07:00
Kubernetes Submit Queue
40d56695f7 Merge pull request #43106 from piosz/bump-rescheduler
Automatic merge from submit-queue (batch tested with PRs 43106, 43110)

Bumped rescheduler version to 0.3.0

fix #32531

https://github.com/kubernetes/contrib/pull/2474 needs to be merged first

cc @ethernetdan @marun @k82cn @aveshagarwal
2017-03-15 06:14:19 -07:00
Shyam Jeedigunta
63e1c78bc7 Add -p to mkdirs in gci-mounter function of gce configure.sh script 2017-03-15 14:04:06 +01:00
Kubernetes Submit Queue
6e05e1c50a Merge pull request #43070 from mikedanese/downfix
Automatic merge from submit-queue

add a compatibility shim for certs to support a cluster downgrade

Fixes https://github.com/kubernetes/kubernetes/issues/42660
2017-03-15 05:16:27 -07:00
Piotr Szczesniak
b7ddd18037 Bumped rescheduler version to 0.3.0 2017-03-15 12:15:13 +01:00
Kubernetes Submit Queue
8993397a1e Merge pull request #42846 from msau42/pd-flake
Automatic merge from submit-queue

Retry calls to ReadFileViaContainer in PD tests

**What this PR does / why we need it**:
kubectl exec occasionally fails to return a valid output string.  It seems to be an issue with docker #34256.  This PR retries the 'kubectl exec' call to workaround the issue.  This should fix the flaky PD test issues.

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #28283

**Release note**:

NONE
2017-03-14 23:55:03 -07:00
Kubernetes Submit Queue
222f69cf3c Merge pull request #43030 from yujuhong/rm_corrupted_checkpoint
Automatic merge from submit-queue (batch tested with PRs 42747, 43030)

dockershim: remove corrupted sandbox checkpoints

This is a workaround to ensure that kubelet doesn't block forever when
the checkpoint is corrupted.

This is a workaround for #43021
2017-03-14 22:56:20 -07:00
Kubernetes Submit Queue
1b4433d4c3 Merge pull request #42747 from dcbw/iptables-proxy-optimize
Automatic merge from submit-queue (batch tested with PRs 42747, 43030)

kube-proxy/iptables: optimize endpoint map creation by excluding invalid endpoints earlier

We don't need to do as much work as we were doing, if we exclude invalid endpoints earlier in the endpoints processing.

Fixes: https://github.com/kubernetes/kubernetes/issues/42210

@freehan @liggitt @thockin if you could review this with a fine-toothed comb...  I can't immediately think of why invalid endpoints would be useful for the HealthChecker, and this PR prevents the HC from seeing these endpoints.
2017-03-14 22:56:18 -07:00
Kubernetes Submit Queue
49dfbfa6bd Merge pull request #42586 from monopole/dedupContributing
Automatic merge from submit-queue

Deduplicate and consolidate contributing information to community repo

* Move remaining community stuff out of kubernetes/kubernetes/README and
   CONTRIBUTING (to kubernets/community/README) so that there's only one thing
   to maintain.
 * Put self-contained things into their own MD files.
 * Have other docs point to those files rather than attempt to repeat their content.
 * Make all docs smaller.

This PR is a companion to kubernetes/community#434

Closes kubernetes/community#420
2017-03-14 21:12:56 -07:00
Kubernetes Submit Queue
792a24ac01 Merge pull request #43118 from yujuhong/sync_checkpoint
Automatic merge from submit-queue

dockershim: call sync() after writing the checkpoint

This ensures the checkpoint files are persisted.

This fixes #43021
2017-03-14 21:12:49 -07:00
Kubernetes Submit Queue
a19210f418 Merge pull request #43096 from deads2k/update-patch
Automatic merge from submit-queue

vendor: Update github.com/evanphx/json-patch

Regenerated files for https://github.com/kubernetes/kubernetes/pull/40387


Fixes #40218
2017-03-14 19:44:05 -07:00
Kubernetes Submit Queue
586fd3374f Merge pull request #43090 from foxish/fix-network-partition-flake
Automatic merge from submit-queue (batch tested with PRs 42854, 43105, 43090)

Add a timeout to allow replacement pod to become ready

Hopefully fixes https://github.com/kubernetes/kubernetes/issues/37259

```
I0314 04:26:02.562] Mar 14 04:26:02.562: INFO: Pod my-hostname-net-1bgrj still exists
I0314 04:26:22.491] Mar 14 04:26:22.491: INFO: Waiting for pod my-hostname-net-1bgrj to disappear
I0314 04:26:22.496] Mar 14 04:26:22.495: INFO: Pod my-hostname-net-1bgrj no longer exists
I0314 04:26:22.496] STEP: verifying whether the pod from the unreachable node is recreated
I0314 04:26:22.498] Mar 14 04:26:22.498: INFO: Pod name my-hostname-net: Found 3 pods out of 3
I0314 04:26:22.499] STEP: ensuring each pod is running
I0314 04:26:22.499] STEP: trying to dial each unique pod
I0314 04:26:22.579] Mar 14 04:26:22.579: INFO: Controller my-hostname-net: Got expected result from replica 1 [my-hostname-net-5jrdb]: "my-hostname-net-5jrdb", 1 of 3 required successes so far
I0314 04:26:22.642] Mar 14 04:26:22.642: INFO: Controller my-hostname-net: Got expected result from replica 2 [my-hostname-net-mjf3c]: "my-hostname-net-mjf3c", 2 of 3 required successes so far
I0314 04:31:22.645] Mar 14 04:31:22.644: INFO: Controller my-hostname-net: Failed to Get from replica 3 [my-hostname-net-rf46s]: Get https://35.184.87.178/api/v1/namespaces/e2e-tests-network-partition-s5gqt/pods/my-hostname-net-rf46s/proxy/: context deadline exceeded
```

The issue appears to be that we have a race between the pod being "running + ready" and being accessible via the APIServer proxy.


cc @kow3ns @bowei @davidopp
2017-03-14 18:44:22 -07:00
Kubernetes Submit Queue
8f9cba87a9 Merge pull request #43105 from intelsdi-x/reuse-sched-event-predicates
Automatic merge from submit-queue (batch tested with PRs 42854, 43105, 43090)

Move e2e sched event predicates to new file.

**What this PR does / why we need it**:

Small e2e test refactor for scheduler. Moves scheduler event predicates out of opaque_resource.go for reuse elsewhere.

**Release note**:

```release-note
NONE
```

cc @kubernetes/sig-scheduling-pr-reviews @timothysc @bsalamat
2017-03-14 18:44:20 -07:00
Kubernetes Submit Queue
fea42bade0 Merge pull request #42854 from vladimirvivien/scaleio-k8s-fix-readOnly
Automatic merge from submit-queue (batch tested with PRs 42854, 43105, 43090)

Update ScaleIO volume plugin default readOnly value

This commit updates the code to set readOnly attribute to be set to false.

**What this PR does / why we need it**:
This PR is a minor fix that updates the default value of `readOnly` attribute to `false`.

**Release note**:

```release-note
NONE
```
2017-03-14 18:44:18 -07:00