Commit Graph

116045 Commits

Author SHA1 Message Date
Clayton Coleman
166256f73e
kubelet: Reduce the interface pod.Manager consumers accept
Every component that uses a pod.Manager should use a stub interface
(like we do for podWorker) that explicitly describes what methods
they use. This will allow podWorker to implement the minimum set
of manager interfaces.
2023-05-12 12:57:27 -04:00
Clayton Coleman
8bd94dfa76
kubelet: Organize and document kubelet pod-related members
Clearly describe core pod related component responsibilities in
the kubelet members. Organize the PodManager interface for clarity.
2023-05-12 12:57:27 -04:00
Clayton Coleman
bb568844b6
kubelet: Separate the MirrorClient from the PodManager
The two are not coupled except accidentally. Separate them and
update callsites. This will reduce the scope of PodManager interface
to make exposing the pod worker cleaner.
2023-05-12 12:57:26 -04:00
Clayton Coleman
80b1aca580
kubelet: Remove dispatchWork and inline calls to UpdatePod
The HandlePod* methods are all structurally similar, but accrued
subtle differences. In general the only point for Handle is to
process admission and to update the pod worker with the desired
state of the kubelet's config (so that pod worker can make it
the actual state).

Add a new GetPodAndMirrorPod() method that handles when the config
pod is ambiguous (pod or mirror pod) and inline the structure.
Add comments on questionable additions in the config methods for
future improvement.

Move the metric observation of container count closer to where
pods are actually started (in the pod worker). A future change
can likely move it to syncPod.
2023-05-12 12:57:26 -04:00
Clayton Coleman
e7207c8546
kubelet: Merge orphaned mirror pod names into GetPodsAndMirrorPods
There is only one caller and both sets of data are part of the
resync operation between kubelet's desired state and the actual
state of the pod workers. Reduces the size of the interface so
that it is easier to create another pod manager.
2023-05-12 12:57:26 -04:00
Clayton Coleman
f8086f2dac
kubelet: Convert IsMirrorOf to a function
Shrinks the PodManager interface by one method, no abstraction is
necessary here.
2023-05-12 12:57:26 -04:00
Clayton Coleman
02960a8253
kubelet: Remove unused mirrorPodFunc in eviction
Not referenced
2023-05-12 12:57:25 -04:00
Kubernetes Prow Robot
84c8abfb8b
Merge pull request #117961 from humblec/ginkgo
ginkgo update to v2.9.4 and gomega to 1.27.6
2023-05-12 09:39:20 -07:00
Kubernetes Prow Robot
58ba509fe5
Merge pull request #117748 from humblec/autirest
dependencies: update gh/Azure/go-autorest to latest version
2023-05-12 09:39:13 -07:00
Kubernetes Prow Robot
c72bedb6cb
Merge pull request #117670 from carlory/fix-issue-117583
e2e framework: remove dependency on k8s.io/kubernetes/pkg/api/v1/pod
2023-05-12 09:39:01 -07:00
Kubernetes Prow Robot
6d7b0b527d
Merge pull request #117956 from humblec/more-deps
update containerd/ttrpc to v1.2.2
2023-05-12 08:37:13 -07:00
Kubernetes Prow Robot
8f9c185696
Merge pull request #116761 from iancoolidge/devel-cpuset-revendor
Complete cpuset export to k/utils by revendoring
2023-05-12 08:37:02 -07:00
Kubernetes Prow Robot
c056c36e23
Merge pull request #117969 from daman1807/fix/proxy-health-check
Release read lock early in proxy service health check
2023-05-12 06:03:09 -07:00
Kubernetes Prow Robot
831a2f0f5a
Merge pull request #117954 from seans3/invalid-openapi-v3
OpenAPI V3 invalid document checks
2023-05-12 06:03:02 -07:00
Kubernetes Prow Robot
a37783467e
Merge pull request #117941 from pohly/logcheck-update
hack/tools: bump logcheck to v0.5.0
2023-05-12 03:02:46 -07:00
Daman Arora
3dc4eea889 proxy/service_health: release read lock early
Signed-off-by: Daman Arora <aroradaman@gmail.com>
2023-05-12 15:04:04 +05:30
Kubernetes Prow Robot
ac7e5cbf69
Merge pull request #117960 from SataQiu/fix-e2e-20230512
e2e_kubeadm: stop using deprecated framework.ExpectEqual
2023-05-12 00:04:48 -07:00
Sean Sullivan
3da79e2850 OpenAPI V3 invalid document checks 2023-05-11 21:44:45 -07:00
Humble Chirammal
cbe825b2b6 ginkgo update to v2.9.4 and gomega to 1.27.6
https://github.com/onsi/ginkgo/v2/compare/v2.9.1...v2.9.4
 https://github.com/onsi/gomega/compare/v1.27.4...v1.27.6

Signed-off-by: Humble Chirammal <humble.devassy@gmail.com>
2023-05-12 09:38:26 +05:30
SataQiu
feb63fb028 e2e_kubeadm: stop using deprecated framework.ExpectEqual 2023-05-12 11:54:54 +08:00
Humble Chirammal
f03b5cdc08 update containerd/ttrpc to v1.2.2
https://github.com/containerd/ttrpc/compare/v1.2.1...v1.2.2

Signed-off-by: Humble Chirammal <humble.devassy@gmail.com>
2023-05-12 08:21:39 +05:30
carlory
20602c819b e2e framework: remove dependency on k8s.io/kubernetes/pkg/api/v1/pod 2023-05-12 08:39:37 +08:00
Kubernetes Prow Robot
02659772cb
Merge pull request #117931 from tklauser/cidrset-rm-getindexforcidr
cidrset, multicidrset: directly use getIndexForIP method
2023-05-11 10:59:36 -07:00
Kubernetes Prow Robot
06c9a7daee
Merge pull request #117897 from thockin/codegen_deprecate_generate_groups_scripts
Deprecate generate*groups.sh -> kube_codegen.sh
2023-05-11 10:59:28 -07:00
Kubernetes Prow Robot
906a488819
Merge pull request #117893 from soltysh/improve_statefulset_tests
When expecting pods count only active ones
2023-05-11 10:59:21 -07:00
Kubernetes Prow Robot
7522cb2c1f
Merge pull request #117650 from tklauser/wait-correct-comment
wait: fix PollUntilContextTimeout godoc comment
2023-05-11 10:59:14 -07:00
Kubernetes Prow Robot
58e13496d6
Merge pull request #116842 from mengjiao-liu/contextual-logging-scheduler-runtime
Migrated `pkg/scheduler/framework/runtime` to use contextual logging
2023-05-11 10:59:02 -07:00
Kubernetes Prow Robot
367180d781
Merge pull request #117933 from tenzen-y/replace-deprecated-Prt-utils
Job: Replace deprecated pointer utils with supported ones
2023-05-11 09:59:14 -07:00
Kubernetes Prow Robot
87af78dba7
Merge pull request #117907 from SataQiu/fix-controller-log-20230510
Fix a bug where the AttachedVolume is not printed correctly in the log
2023-05-11 09:59:02 -07:00
Kubernetes Prow Robot
a4f3ebf84b
Merge pull request #117932 from bart0sh/PR114-e2e-DRA-use-containerd-1.7
DRA: use containerd 1.7 in kind image
2023-05-11 08:59:13 -07:00
Kubernetes Prow Robot
64af2d93e5
Merge pull request #117295 from aojea/transport_cache_metrics
add new metric for the internal client-go cache size
2023-05-11 08:59:02 -07:00
Patrick Ohly
1ea17254bf hack/tools: bump logcheck to v0.5.0 2023-05-11 16:54:26 +02:00
SataQiu
3fa55d469c fix a bug where the AttachedVolume is not printed correctly in the log 2023-05-11 22:04:30 +08:00
Kubernetes Prow Robot
e1ad9bee5b
Merge pull request #117902 from TommyStarK/doc/e2e-dra
test/e2e/dra: update README
2023-05-11 04:15:18 -07:00
Maciej Szulik
8c82855467
When expecting pods count only active ones 2023-05-11 13:04:42 +02:00
Yuki Iwai
de882f5193 Job: Replace deprecated pointer utils with supported ones
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
2023-05-11 19:29:14 +09:00
Ed Bartosh
8f11f5bb2b DRA: use containerd 1.7 in kind image
As Containerd 1.6 doesn't support CDI we want to stay
closer to 1.7

Containerd 1.7 is going to be the first official
release with full CDI support.
2023-05-11 12:47:23 +03:00
Antonio Ojea
3f3e1d507d add new metrics for the internal client-go transport generator
Add two new metrics to monitor the client-go logic that
generate http.Transports for the clients.

- rest_client_transport_cache_entries is a gauge metrics
with the number of existin entries in the internal cache

- rest_client_transport_create_calls_total is a counter
that increments each time a new transport is created, storing
the result of the operation needed to generate it: hit, miss
or uncacheable

Change-Id: I2d8bde25281153d8f8e8faa249385edde3c1cb39
2023-05-11 09:07:11 +00:00
Tobias Klauser
e7c679c362
cidrset, multicidrset: directly use getIndexForIP method
Instead of constructing a *net.IPnet whose .Mask field is never used,
call the getIndexForIP method of *CidrSet and *MultiCIDRSet directly.
2023-05-11 10:53:03 +02:00
Mengjiao Liu
fe728996ca scheduler test: call frameworkruntime.WithLogger function for contextual logging 2023-05-11 15:46:08 +08:00
Mengjiao Liu
b456392567 Migrated pkg/scheduler/framework/runtime to use contextual logging 2023-05-11 15:46:02 +08:00
Kubernetes Prow Robot
122a459dcb
Merge pull request #117616 from claudiubelu/fix-kubelet-util-windows-ut
unit tests: Fixes kubelet util unit tests for Windows
2023-05-10 19:51:09 -07:00
Kubernetes Prow Robot
006c0110aa
Merge pull request #117912 from bart0sh/PR113-fix-e2e-dra-kind-build-image.sh
DRA: fix image build on Mac
2023-05-10 16:23:13 -07:00
TommyStarK
3b634de6ff test/e2e/dra: update README
Signed-off-by: TommyStarK <thomasmilox@gmail.com>
2023-05-10 23:29:10 +02:00
Kubernetes Prow Robot
afbedee925
Merge pull request #117796 from seans3/fallback-invalid-doc-fix
QueryParamVerifier falls back on invalid v3 document
2023-05-10 14:03:15 -07:00
Kubernetes Prow Robot
c2efaa7908
Merge pull request #116526 from pacoxu/cluster-autoscaler-upgrade
upgrade cluster-autoscaler v1.26.1 to fix ci warnings
2023-05-10 13:07:14 -07:00
Sean Sullivan
5fdeaa8e42 update for feedback 2023-05-10 19:13:54 +00:00
Kubernetes Prow Robot
4e12a5f60f
Merge pull request #117913 from daman1807/fix/curl-timeout
using --max-time instead of --connect-timeout for e2e/network/service tests.
2023-05-10 12:09:10 -07:00
Kubernetes Prow Robot
19aaf0c0e1
Merge pull request #117724 from dlipovetsky/kubeadm-remove-etcd-member-idempotent
kubeadm: Make etcd member removal idempotent
2023-05-10 12:08:59 -07:00
Sean Sullivan
6f23c77408 QueryParamVerifier falls back on invalid v3 document 2023-05-10 18:30:16 +00:00